Re: [PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

2017-10-25 Thread Dmitry Torokhov
On Wed, Oct 25, 2017 at 03:37:35PM +0200, Benjamin Tissoires wrote: > On Oct 24 2017 or thereabouts, Andrew Duggan wrote: > > By convention the first 6 bits of F30 Ctrl 2 and 3 are used to signify > > I really do not like the "by convention". What if future firmware > developers are willing to

Re: [PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

2017-10-25 Thread Dmitry Torokhov
On Wed, Oct 25, 2017 at 03:37:35PM +0200, Benjamin Tissoires wrote: > On Oct 24 2017 or thereabouts, Andrew Duggan wrote: > > By convention the first 6 bits of F30 Ctrl 2 and 3 are used to signify > > I really do not like the "by convention". What if future firmware > developers are willing to

Re: [PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

2017-10-25 Thread Benjamin Tissoires
On Oct 24 2017 or thereabouts, Andrew Duggan wrote: > By convention the first 6 bits of F30 Ctrl 2 and 3 are used to signify I really do not like the "by convention". What if future firmware developers are willing to add extra buttons and already have trackstick buttons there, meaning the max 6

Re: [PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

2017-10-25 Thread Benjamin Tissoires
On Oct 24 2017 or thereabouts, Andrew Duggan wrote: > By convention the first 6 bits of F30 Ctrl 2 and 3 are used to signify I really do not like the "by convention". What if future firmware developers are willing to add extra buttons and already have trackstick buttons there, meaning the max 6

Re: [PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

2017-10-25 Thread Daniel Martin
On 25 October 2017 at 05:42, Andrew Duggan wrote: > By convention the first 6 bits of F30 Ctrl 2 and 3 are used to signify > GPIOs which are connected to buttons. Additional GPIOs may be used as > input GPIOs to signal the touch controller of some event > (ie disable

Re: [PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

2017-10-25 Thread Daniel Martin
On 25 October 2017 at 05:42, Andrew Duggan wrote: > By convention the first 6 bits of F30 Ctrl 2 and 3 are used to signify > GPIOs which are connected to buttons. Additional GPIOs may be used as > input GPIOs to signal the touch controller of some event > (ie disable touchpad). These additional

[PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

2017-10-24 Thread Andrew Duggan
By convention the first 6 bits of F30 Ctrl 2 and 3 are used to signify GPIOs which are connected to buttons. Additional GPIOs may be used as input GPIOs to signal the touch controller of some event (ie disable touchpad). These additional GPIOs may meet the criteria of a button in

[PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

2017-10-24 Thread Andrew Duggan
By convention the first 6 bits of F30 Ctrl 2 and 3 are used to signify GPIOs which are connected to buttons. Additional GPIOs may be used as input GPIOs to signal the touch controller of some event (ie disable touchpad). These additional GPIOs may meet the criteria of a button in