Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Wed, May 31, 2017 at 10:11:14PM +0100, Nick Dyer wrote: > On Tue, May 30, 2017 at 09:59:13AM -0700, Dmitry Torokhov wrote: > > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > > Instead of printing bytes one by

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Wed, May 31, 2017 at 10:11:14PM +0100, Nick Dyer wrote: > On Tue, May 30, 2017 at 09:59:13AM -0700, Dmitry Torokhov wrote: > > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > > Instead of printing bytes one by

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Tue, May 30, 2017 at 09:59:13AM -0700, Dmitry Torokhov wrote: > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > Instead of printing bytes one by one, let's use %phN to print the buffer > > > in > > > one go. >

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Tue, May 30, 2017 at 09:59:13AM -0700, Dmitry Torokhov wrote: > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > Instead of printing bytes one by one, let's use %phN to print the buffer > > > in > > > one go. >

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Tue, 2017-05-30 at 22:04 +0300, Andy Shevchenko wrote: > On Tue, 2017-05-30 at 10:23 -0700, Joe Perches wrote: > > On Tue, 2017-05-30 at 09:59 -0700, Dmitry Torokhov wrote: > > > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > > > On May 29 2017 or thereabouts, Dmitry

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Tue, 2017-05-30 at 22:04 +0300, Andy Shevchenko wrote: > On Tue, 2017-05-30 at 10:23 -0700, Joe Perches wrote: > > On Tue, 2017-05-30 at 09:59 -0700, Dmitry Torokhov wrote: > > > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > > > On May 29 2017 or thereabouts, Dmitry

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Tue, 2017-05-30 at 10:23 -0700, Joe Perches wrote: > On Tue, 2017-05-30 at 09:59 -0700, Dmitry Torokhov wrote: > > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > > > > Or we'd need to introduce %pH I guess.

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Tue, 2017-05-30 at 10:23 -0700, Joe Perches wrote: > On Tue, 2017-05-30 at 09:59 -0700, Dmitry Torokhov wrote: > > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > > > > Or we'd need to introduce %pH I guess.

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Tue, 2017-05-30 at 09:59 -0700, Dmitry Torokhov wrote: > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > Instead of printing bytes one by one, let's use %phN to print the buffer > > > in > > > one go. > > > >

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Tue, 2017-05-30 at 09:59 -0700, Dmitry Torokhov wrote: > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > Instead of printing bytes one by one, let's use %phN to print the buffer > > > in > > > one go. > > > >

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > Instead of printing bytes one by one, let's use %phN to print the buffer in > > one go. > > > > Also use hweight8 to count number of partitions instead of inspecting it

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > Instead of printing bytes one by one, let's use %phN to print the buffer in > > one go. > > > > Also use hweight8 to count number of partitions instead of inspecting it

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > Instead of printing bytes one by one, let's use %phN to print the buffer in > one go. > > Also use hweight8 to count number of partitions instead of inspecting it > bit by bit. > > Signed-off-by: Dmitry Torokhov

Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > Instead of printing bytes one by one, let's use %phN to print the buffer in > one go. > > Also use hweight8 to count number of partitions instead of inspecting it > bit by bit. > > Signed-off-by: Dmitry Torokhov > --- Looks good to me:

[PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

Instead of printing bytes one by one, let's use %phN to print the buffer in one go. Also use hweight8 to count number of partitions instead of inspecting it bit by bit. Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_f34v7.c | 22 -- 1

[PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID

Instead of printing bytes one by one, let's use %phN to print the buffer in one go. Also use hweight8 to count number of partitions instead of inspecting it bit by bit. Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_f34v7.c | 22 -- 1 file changed, 8