Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Mingming Cao
On Wed, 2007-09-19 at 13:48 -0600, Andreas Dilger wrote: > On Sep 19, 2007 12:15 -0700, Mingming Cao wrote: > > @@ -96,8 +96,7 @@ static int start_this_handle(journal_t * > > > > alloc_transaction: > > if (!journal->j_running_transaction) { > > - new_transaction = kmalloc(sizeof(*

Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Mingming Cao
On Wed, 2007-09-19 at 19:28 +, Dave Kleikamp wrote: > On Wed, 2007-09-19 at 14:26 -0500, Dave Kleikamp wrote: > > On Wed, 2007-09-19 at 12:15 -0700, Mingming Cao wrote: > > > > > Here is the patch to clean up __GFP_NOFAIL flag in jbd/jbd2. In all > > > cases except one handles memory allocatio

Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Andreas Dilger
On Sep 19, 2007 12:15 -0700, Mingming Cao wrote: > @@ -96,8 +96,7 @@ static int start_this_handle(journal_t * > > alloc_transaction: > if (!journal->j_running_transaction) { > - new_transaction = kmalloc(sizeof(*new_transaction), > -

Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Dave Kleikamp
On Wed, 2007-09-19 at 14:26 -0500, Dave Kleikamp wrote: > On Wed, 2007-09-19 at 12:15 -0700, Mingming Cao wrote: > > > Here is the patch to clean up __GFP_NOFAIL flag in jbd/jbd2. In all > > cases except one handles memory allocation failure so I get rid of those > > GFP_NOFAIL flags. > > > > Als

Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Dave Kleikamp
On Wed, 2007-09-19 at 12:15 -0700, Mingming Cao wrote: > Here is the patch to clean up __GFP_NOFAIL flag in jbd/jbd2. In all > cases except one handles memory allocation failure so I get rid of those > GFP_NOFAIL flags. > > Also, shouldn't we use GFP_KERNEL instead of GFP_NOFS flag for kmalloc >

Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Mingming Cao
On Tue, 2007-09-18 at 19:19 -0700, Andrew Morton wrote: > On Tue, 18 Sep 2007 18:00:01 -0700 Mingming Cao <[EMAIL PROTECTED]> wrote: > > > JBD: Replace slab allocations with page cache allocations > > > > JBD allocate memory for committed_data and frozen_data from slab. However > > JBD should not

Re: [PATCH] JBD slab cleanups

2007-09-18 Thread Andrew Morton
On Tue, 18 Sep 2007 18:00:01 -0700 Mingming Cao <[EMAIL PROTECTED]> wrote: > JBD: Replace slab allocations with page cache allocations > > JBD allocate memory for committed_data and frozen_data from slab. However > JBD should not pass slab pages down to the block layer. Use page allocator > page

Re: [PATCH] JBD slab cleanups

2007-09-18 Thread Mingming Cao
On Tue, 2007-09-18 at 13:04 -0500, Dave Kleikamp wrote: > On Tue, 2007-09-18 at 09:35 -0700, Mingming Cao wrote: > > On Tue, 2007-09-18 at 10:04 +0100, Christoph Hellwig wrote: > > > On Mon, Sep 17, 2007 at 03:57:31PM -0700, Mingming Cao wrote: > > > > Here is the incremental small cleanup patch.

Re: [PATCH] JBD slab cleanups

2007-09-18 Thread Dave Kleikamp
On Tue, 2007-09-18 at 09:35 -0700, Mingming Cao wrote: > On Tue, 2007-09-18 at 10:04 +0100, Christoph Hellwig wrote: > > On Mon, Sep 17, 2007 at 03:57:31PM -0700, Mingming Cao wrote: > > > Here is the incremental small cleanup patch. > > > > > > Remove kamlloc usages in jbd/jbd2 and consistently

Re: [PATCH] JBD slab cleanups

2007-09-18 Thread Mingming Cao
On Tue, 2007-09-18 at 10:04 +0100, Christoph Hellwig wrote: > On Mon, Sep 17, 2007 at 03:57:31PM -0700, Mingming Cao wrote: > > Here is the incremental small cleanup patch. > > > > Remove kamlloc usages in jbd/jbd2 and consistently use > > jbd_kmalloc/jbd2_malloc. > > Shouldn't we kill jbd_kmal

Re: [PATCH] JBD slab cleanups

2007-09-18 Thread Christoph Hellwig
On Mon, Sep 17, 2007 at 03:57:31PM -0700, Mingming Cao wrote: > Here is the incremental small cleanup patch. > > Remove kamlloc usages in jbd/jbd2 and consistently use > jbd_kmalloc/jbd2_malloc. Shouldn't we kill jbd_kmalloc instead? - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] JBD slab cleanups

2007-09-17 Thread Mingming Cao
On Mon, 2007-09-17 at 15:01 -0700, Badari Pulavarty wrote: > On Mon, 2007-09-17 at 12:29 -0700, Mingming Cao wrote: > > On Fri, 2007-09-14 at 11:53 -0700, Mingming Cao wrote: > > > jbd/jbd2: Replace slab allocations with page cache allocations > > > > > > From: Christoph Lameter <[EMAIL PROTECTED]

Re: [PATCH] JBD slab cleanups

2007-09-17 Thread Badari Pulavarty
On Mon, 2007-09-17 at 12:29 -0700, Mingming Cao wrote: > On Fri, 2007-09-14 at 11:53 -0700, Mingming Cao wrote: > > jbd/jbd2: Replace slab allocations with page cache allocations > > > > From: Christoph Lameter <[EMAIL PROTECTED]> > > > > JBD should not pass slab pages down to the block layer. >

Re: [PATCH] JBD slab cleanups

2007-09-17 Thread Christoph Hellwig
On Mon, Sep 17, 2007 at 12:29:51PM -0700, Mingming Cao wrote: > The problem with this patch, as Andreas Dilger pointed today in ext4 > interlock call, for 1k,2k block size ext2/3/4, get_free_pages() waste > 1/3-1/2 page space. > > What was the originally intention to set up slabs for committed_da

Re: [PATCH] JBD slab cleanups

2007-09-17 Thread Mingming Cao
On Fri, 2007-09-14 at 11:53 -0700, Mingming Cao wrote: > jbd/jbd2: Replace slab allocations with page cache allocations > > From: Christoph Lameter <[EMAIL PROTECTED]> > > JBD should not pass slab pages down to the block layer. > Use page allocator pages instead. This will also prepare > JBD for

Re: [PATCH] JBD slab cleanups

2007-09-14 Thread Christoph Lameter
Thanks Mingming. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] JBD slab cleanups

2007-09-14 Thread Mingming Cao
jbd/jbd2: Replace slab allocations with page cache allocations From: Christoph Lameter <[EMAIL PROTECTED]> JBD should not pass slab pages down to the block layer. Use page allocator pages instead. This will also prepare JBD for the large blocksize patchset. Tested on 2.6.23-rc6 with fsx runs fin