Re: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new()

2017-09-21 Thread Eric Biggers
On Tue, Sep 19, 2017 at 04:46:08PM +0100, David Howells wrote: > Eric Biggers wrote: > > > In request_key_auth_new(), if alloc_key() or key_instantiate_and_link() > > were to fail, we would leak a reference to the 'struct cred'. Currently > > this can only happen if

Re: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new()

2017-09-21 Thread Eric Biggers
On Tue, Sep 19, 2017 at 04:46:08PM +0100, David Howells wrote: > Eric Biggers wrote: > > > In request_key_auth_new(), if alloc_key() or key_instantiate_and_link() > > were to fail, we would leak a reference to the 'struct cred'. Currently > > this can only happen if alloc_key() fails to to

Re: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new()

2017-09-19 Thread David Howells
Eric Biggers wrote: > In request_key_auth_new(), if alloc_key() or key_instantiate_and_link() > were to fail, we would leak a reference to the 'struct cred'. Currently > this can only happen if alloc_key() fails to to allocate memory. But it > still should be fixed, as it

Re: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new()

2017-09-19 Thread David Howells
Eric Biggers wrote: > In request_key_auth_new(), if alloc_key() or key_instantiate_and_link() > were to fail, we would leak a reference to the 'struct cred'. Currently > this can only happen if alloc_key() fails to to allocate memory. But it > still should be fixed, as it is a more severe bug

[PATCH] KEYS: fix cred refcount leak in request_key_auth_new()

2017-09-18 Thread Eric Biggers
From: Eric Biggers In request_key_auth_new(), if alloc_key() or key_instantiate_and_link() were to fail, we would leak a reference to the 'struct cred'. Currently this can only happen if alloc_key() fails to to allocate memory. But it still should be fixed, as it is a more

[PATCH] KEYS: fix cred refcount leak in request_key_auth_new()

2017-09-18 Thread Eric Biggers
From: Eric Biggers In request_key_auth_new(), if alloc_key() or key_instantiate_and_link() were to fail, we would leak a reference to the 'struct cred'. Currently this can only happen if alloc_key() fails to to allocate memory. But it still should be fixed, as it is a more severe bug waiting