Re: [PATCH] KEYS: remove redundant memsets

t...@redhat.com wrote: > - if (copy_from_user(&uparams, _params, sizeof(uparams)) != 0) > - return -EFAULT; > - > ret = keyctl_pkey_params_get(uparams.key_id, _info, params); Erm... uparams is used on the very next statement after the copy_from_user(). David

Re: [PATCH] KEYS: remove redundant memsets

Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on security/next-testing] [also build test WARNING on linus/master dhowells-fs/fscache-next v5.8-rc6 next-20200721] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patc

[PATCH] KEYS: remove redundant memsets

From: Tom Rix Reviewing use of memset in keyctrl_pkey.c keyctl_pkey_params_get prologue code to set params up memset(params, 0, sizeof(*params)); params->encoding = "raw"; keyctl_pkey_params_get_2 and keyctl_pkey_query have the same prologue and they call keyctl_pkey_params_get