Re: [PATCH] KVM: LAPIC: ARBPRI is a reserved register for x2APIC

2019-07-05 Thread Nadav Amit
> On Jul 5, 2019, at 6:43 AM, Paolo Bonzini wrote: > > On 05/07/19 15:37, Nadav Amit wrote: >>> On Jul 5, 2019, at 5:14 AM, Paolo Bonzini wrote: >>> >>> kvm-unit-tests were adjusted to match bare metal behavior, but KVM >>> itself was not doing what bare metal does; fix that. >>> >>>

Re: [PATCH] KVM: LAPIC: ARBPRI is a reserved register for x2APIC

2019-07-05 Thread Paolo Bonzini
On 05/07/19 15:37, Nadav Amit wrote: >> On Jul 5, 2019, at 5:14 AM, Paolo Bonzini wrote: >> >> kvm-unit-tests were adjusted to match bare metal behavior, but KVM >> itself was not doing what bare metal does; fix that. >> >> Signed-off-by: Paolo Bonzini > > Reported-by ? I found it myself while

Re: [PATCH] KVM: LAPIC: ARBPRI is a reserved register for x2APIC

2019-07-05 Thread Nadav Amit
> On Jul 5, 2019, at 5:14 AM, Paolo Bonzini wrote: > > kvm-unit-tests were adjusted to match bare metal behavior, but KVM > itself was not doing what bare metal does; fix that. > > Signed-off-by: Paolo Bonzini Reported-by ?

Re: [PATCH] KVM: LAPIC: ARBPRI is a reserved register for x2APIC

2019-07-05 Thread Paolo Bonzini
On 05/07/19 14:37, Liran Alon wrote: >> +u64 rmask = 0x43ff01ffe70cULL; > Why not rename this to “used_bits_mask” and calculate it properly by macros? > It seems a lot nicer than having a pre-calculated magic. Yes, I wanted to do the same but I didn't have time right now. I am planning

Re: [PATCH] KVM: LAPIC: ARBPRI is a reserved register for x2APIC

2019-07-05 Thread Liran Alon
> On 5 Jul 2019, at 15:14, Paolo Bonzini wrote: > > kvm-unit-tests were adjusted to match bare metal behavior, but KVM > itself was not doing what bare metal does; fix that. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/lapic.c | 6 +- > 1 file changed, 5 insertions(+), 1

[PATCH] KVM: LAPIC: ARBPRI is a reserved register for x2APIC

2019-07-05 Thread Paolo Bonzini
kvm-unit-tests were adjusted to match bare metal behavior, but KVM itself was not doing what bare metal does; fix that. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c