Re: [PATCH] KVM: SVM: Initialize ir_list and ir_list_lock regardless of AVIC enablement

2020-10-03 Thread Suravee Suthikulpanit
Paolo, On 9/28/20 3:01 PM, Paolo Bonzini wrote: On 28/09/20 07:53, Suravee Suthikulpanit wrote: Hi, Are there any issues or concerns about this patch? Yes, sorry I haven't replied yet. Looks like Linus is doing an -rc8 so there's plenty of time to have it in 5.9. The thing I'm wondering is

Re: [PATCH] KVM: SVM: Initialize ir_list and ir_list_lock regardless of AVIC enablement

2020-09-28 Thread Paolo Bonzini
On 28/09/20 07:53, Suravee Suthikulpanit wrote: > Hi, > > Are there any issues or concerns about this patch? Yes, sorry I haven't replied yet. Looks like Linus is doing an -rc8 so there's plenty of time to have it in 5.9. The thing I'm wondering is, why is svm_update_pi_irte doing anything if y

Re: [PATCH] KVM: SVM: Initialize ir_list and ir_list_lock regardless of AVIC enablement

2020-09-27 Thread Suravee Suthikulpanit
Hi, Are there any issues or concerns about this patch? Thank you, Suravee On 9/22/20 3:44 PM, Suravee Suthikulpanit wrote: The struct vcpu_svm.ir_list and ir_list_lock are being accessed even when AVIC is not enabled, while current code only initialize the list and the lock only when AVIC is e

[PATCH] KVM: SVM: Initialize ir_list and ir_list_lock regardless of AVIC enablement

2020-09-22 Thread Suravee Suthikulpanit
The struct vcpu_svm.ir_list and ir_list_lock are being accessed even when AVIC is not enabled, while current code only initialize the list and the lock only when AVIC is enabled. This ended up trigger NULL pointer dereference bug in the function vm_ir_list_del with the following call trace: sv