Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure

2015-04-29 Thread Paolo Bonzini
On 29/04/2015 18:08, Bandan Das wrote: >> > Yeah... I hear you. Ok, let me put it this way - Assume that we can >> > defer this allocation up until the point that the nested subsystem is >> > actually used i.e L1 tries running a guest and we try to allocate this >> > area. If

Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure

2015-04-29 Thread Bandan Das
Paolo Bonzini writes: > On 29/04/2015 15:05, Jan Kiszka wrote: >> > Yeah... I hear you. Ok, let me put it this way - Assume that we can >> > defer this allocation up until the point that the nested subsystem is >> > actually used i.e L1 tries running a guest and we try to allocate this >> > area.

Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure

2015-04-29 Thread Paolo Bonzini
On 29/04/2015 15:05, Jan Kiszka wrote: > > Yeah... I hear you. Ok, let me put it this way - Assume that we can > > defer this allocation up until the point that the nested subsystem is > > actually used i.e L1 tries running a guest and we try to allocate this > > area. If get_free_page() failed i

Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure

2015-04-29 Thread Jan Kiszka
Am 2015-04-29 um 14:55 schrieb Bandan Das: > Jan Kiszka writes: > >> Am 2015-04-28 um 21:55 schrieb Bandan Das: >>> >>> If get_free_page() fails for nested bitmap area, it's evident that >>> we are gonna get screwed anyway but returning failure because we failed >>> allocating memory for a nested

Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure

2015-04-29 Thread Bandan Das
Jan Kiszka writes: > Am 2015-04-28 um 21:55 schrieb Bandan Das: >> >> If get_free_page() fails for nested bitmap area, it's evident that >> we are gonna get screwed anyway but returning failure because we failed >> allocating memory for a nested structure seems like an unnecessary big >> hammer.

Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure

2015-04-29 Thread Paolo Bonzini
On 29/04/2015 09:27, Nadav Amit wrote: > free_page appears to check whether the address is zero before it actually > frees the page. Perhaps it is better to leverage this behaviour to remove > all the outX and simplify the code. Agreed. Regarding this patch, I agree with Jan. Paolo -- To unsub

Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure

2015-04-29 Thread Nadav Amit
Bandan Das wrote: > > If get_free_page() fails for nested bitmap area, it's evident that > we are gonna get screwed anyway but returning failure because we failed > allocating memory for a nested structure seems like an unnecessary big > hammer. Also, save the call for later; after we are done

Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure

2015-04-29 Thread Jan Kiszka
Am 2015-04-28 um 21:55 schrieb Bandan Das: > > If get_free_page() fails for nested bitmap area, it's evident that > we are gonna get screwed anyway but returning failure because we failed > allocating memory for a nested structure seems like an unnecessary big > hammer. Also, save the call for lat

[PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure

2015-04-28 Thread Bandan Das
If get_free_page() fails for nested bitmap area, it's evident that we are gonna get screwed anyway but returning failure because we failed allocating memory for a nested structure seems like an unnecessary big hammer. Also, save the call for later; after we are done with other non-nested allocatio