Re: [PATCH] KVM: nVMX: VMX instructions: fix segment checks when L1 is in long mode.

2016-06-29 Thread Paolo Bonzini
On 29/06/2016 19:25, Quentin Casasnovas wrote: > On Fri, Jun 24, 2016 at 03:10:03PM +0200, Paolo Bonzini wrote: >> On 24/06/2016 15:04, Quentin Casasnovas wrote: >>> On Thu, Jun 23, 2016 at 06:03:01PM +0200, Paolo Bonzini wrote: On 18/06/2016 11:01, Quentin Casasnovas wrote: >

Re: [PATCH] KVM: nVMX: VMX instructions: fix segment checks when L1 is in long mode.

2016-06-29 Thread Quentin Casasnovas
On Fri, Jun 24, 2016 at 03:10:03PM +0200, Paolo Bonzini wrote: > On 24/06/2016 15:04, Quentin Casasnovas wrote: > > On Thu, Jun 23, 2016 at 06:03:01PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 18/06/2016 11:01, Quentin Casasnovas wrote: > >>> Cross-checking the KVM/VMX VMREAD emulation code wit

Re: [PATCH] KVM: nVMX: VMX instructions: fix segment checks when L1 is in long mode.

2016-06-24 Thread Paolo Bonzini
On 24/06/2016 15:04, Quentin Casasnovas wrote: > On Thu, Jun 23, 2016 at 06:03:01PM +0200, Paolo Bonzini wrote: >> >> >> On 18/06/2016 11:01, Quentin Casasnovas wrote: >>> Cross-checking the KVM/VMX VMREAD emulation code with the Intel Software >>> Developper Manual Volume 3C - "VMREAD - Read Fie

Re: [PATCH] KVM: nVMX: VMX instructions: fix segment checks when L1 is in long mode.

2016-06-24 Thread Quentin Casasnovas
On Thu, Jun 23, 2016 at 06:03:01PM +0200, Paolo Bonzini wrote: > > > On 18/06/2016 11:01, Quentin Casasnovas wrote: > > Cross-checking the KVM/VMX VMREAD emulation code with the Intel Software > > Developper Manual Volume 3C - "VMREAD - Read Field from Virtual-Machine > > Control Structure", I fo

Re: [PATCH] KVM: nVMX: VMX instructions: fix segment checks when L1 is in long mode.

2016-06-23 Thread Paolo Bonzini
On 18/06/2016 11:01, Quentin Casasnovas wrote: > Cross-checking the KVM/VMX VMREAD emulation code with the Intel Software > Developper Manual Volume 3C - "VMREAD - Read Field from Virtual-Machine > Control Structure", I found that we're enforcing that the destination > operand is NOT located in a

[PATCH] KVM: nVMX: VMX instructions: fix segment checks when L1 is in long mode.

2016-06-18 Thread Quentin Casasnovas
I couldn't get Xen to boot a L2 HVM when it was nested under KVM - it was getting a GP(0) on a rather unspecial vmread from Xen: (XEN) [ Xen-4.7.0-rc x86_64 debug=n Not tainted ] (XEN) CPU:1 (XEN) RIP:e008:[] vmx_get_segment_register+0x14e/0x450 (XEN) RFLAGS