Re: [PATCH] KVM: nVMX: cleanup and fix host 64-bit mode checks

2019-09-26 Thread Liran Alon
> On 25 Sep 2019, at 19:34, Paolo Bonzini wrote: > > KVM was incorrectly checking vmcs12->host_ia32_efer even if the "load > IA32_EFER" exit control was reset. Also, some checks were not using > the new CC macro for tracing. > > Cleanup everything so that the vCPU's 64-bit mode is determined

Re: [PATCH] KVM: nVMX: cleanup and fix host 64-bit mode checks

2019-09-26 Thread Paolo Bonzini
On 26/09/19 01:55, Krish Sadhukhan wrote: > > > On 09/25/2019 09:47 AM, Jim Mattson wrote: >> On Wed, Sep 25, 2019 at 9:34 AM Paolo Bonzini >> wrote: >>> KVM was incorrectly checking vmcs12->host_ia32_efer even if the "load >>> IA32_EFER" exit control was reset.  Also, some checks were not using

Re: [PATCH] KVM: nVMX: cleanup and fix host 64-bit mode checks

2019-09-25 Thread Krish Sadhukhan
On 09/25/2019 09:47 AM, Jim Mattson wrote: On Wed, Sep 25, 2019 at 9:34 AM Paolo Bonzini wrote: KVM was incorrectly checking vmcs12->host_ia32_efer even if the "load IA32_EFER" exit control was reset. Also, some checks were not using the new CC macro for tracing. Cleanup everything so that

Re: [PATCH] KVM: nVMX: cleanup and fix host 64-bit mode checks

2019-09-25 Thread Jim Mattson
On Wed, Sep 25, 2019 at 9:34 AM Paolo Bonzini wrote: > > KVM was incorrectly checking vmcs12->host_ia32_efer even if the "load > IA32_EFER" exit control was reset. Also, some checks were not using > the new CC macro for tracing. > > Cleanup everything so that the vCPU's 64-bit mode is determined

[PATCH] KVM: nVMX: cleanup and fix host 64-bit mode checks

2019-09-25 Thread Paolo Bonzini
KVM was incorrectly checking vmcs12->host_ia32_efer even if the "load IA32_EFER" exit control was reset. Also, some checks were not using the new CC macro for tracing. Cleanup everything so that the vCPU's 64-bit mode is determined directly from EFER_LMA and the VMCS checks are based on that, whi