Re: [PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured

2012-09-10 Thread Avi Kivity
On 09/09/2012 06:10 PM, Liu, Jinsong wrote: > Avi Kivity wrote: >> On 09/09/2012 05:54 PM, Liu, Jinsong wrote: hrtimers is an intrusive feature, I don't think we should force-enable it. Please change it to a depends on. >>> >>> Hmm, if it changed as >>> config KVM >>> depends

RE: [PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured

2012-09-09 Thread Liu, Jinsong
Avi Kivity wrote: > On 09/09/2012 05:54 PM, Liu, Jinsong wrote: >>> >>> hrtimers is an intrusive feature, I don't think we should >>> force-enable it. Please change it to a depends on. >> >> Hmm, if it changed as >> config KVM >> depends on HIGH_RES_TIMERS >> The item 'Kernel-based Virtual

Re: [PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured

2012-09-09 Thread Avi Kivity
On 09/09/2012 05:54 PM, Liu, Jinsong wrote: >> >> hrtimers is an intrusive feature, I don't think we should force-enable >> it. Please change it to a depends on. > > Hmm, if it changed as > config KVM > depends on HIGH_RES_TIMERS > The item 'Kernel-based Virtual Machine (KVM) support (NEW)

RE: [PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured

2012-09-09 Thread Liu, Jinsong
Avi Kivity wrote: > On 09/07/2012 03:07 PM, Liu, Jinsong wrote: >> Avi Kivity wrote: diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 148ed66..0e64997 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2210,7 +2210,11 @@ int kvm_dev_ioctl_check_extension

Re: [PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured

2012-09-09 Thread Avi Kivity
On 09/07/2012 03:07 PM, Liu, Jinsong wrote: > Avi Kivity wrote: >>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >>> index 148ed66..0e64997 100644 >>> --- a/arch/x86/kvm/x86.c >>> +++ b/arch/x86/kvm/x86.c >>> @@ -2210,7 +2210,11 @@ int kvm_dev_ioctl_check_extension(long ext) >>>

RE: [PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured

2012-09-07 Thread Liu, Jinsong
Avi Kivity wrote: >> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >> index 148ed66..0e64997 100644 >> --- a/arch/x86/kvm/x86.c >> +++ b/arch/x86/kvm/x86.c >> @@ -2210,7 +2210,11 @@ int kvm_dev_ioctl_check_extension(long ext) >> r = kvm_has_tsc_control; break; >> case KVM_

Re: [PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured

2012-09-06 Thread Avi Kivity
On 09/04/2012 06:07 PM, Liu, Jinsong wrote: > From 728a17e2de591b557c3c8ba31076b4bf2ca5ab42 Mon Sep 17 00:00:00 2001 > From: Liu, Jinsong > Date: Wed, 5 Sep 2012 03:18:15 +0800 > Subject: [PATCH] KVM: tsc deadline timer works only when hrtimer high > resolution configured >

[PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured

2012-09-04 Thread Liu, Jinsong
>From 728a17e2de591b557c3c8ba31076b4bf2ca5ab42 Mon Sep 17 00:00:00 2001 From: Liu, Jinsong Date: Wed, 5 Sep 2012 03:18:15 +0800 Subject: [PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured This is for 2 reasons: 1. it's pointless to enable tsc deadline