Re: [PATCH] KVM: x86/mmu: Add '__func__' in rmap_printk()

2021-02-02 Thread Paolo Bonzini
On 27/01/21 18:25, Joe Perches wrote: On Wed, 2021-01-27 at 11:54 +0100, Paolo Bonzini wrote: On 27/01/21 03:08, Stephen Zhang wrote: Given the common pattern: rmap_printk("%s:"..., __func__,...) we could improve this by adding '__func__' in rmap_printk(). Currently, the MMU_DEBUG control i

Re: [PATCH] KVM: x86/mmu: Add '__func__' in rmap_printk()

2021-01-28 Thread Paolo Bonzini
On 27/01/21 19:28, Joe Perches wrote: It's not enabled unless DEBUG is defined (and it's not enabled by default) or CONFIG_DYNAMIC_DEBUG is enabled and then dynamic_debug jump points are used when not enabled so I think any slowdown, even when dynamic_debug is enabled is trivial. Ah, I confused

Re: [PATCH] KVM: x86/mmu: Add '__func__' in rmap_printk()

2021-01-27 Thread Joe Perches
On Wed, 2021-01-27 at 19:23 +0100, Paolo Bonzini wrote: > On 27/01/21 18:25, Joe Perches wrote: > > > > -#ifdef MMU_DEBUG > > -bool dbg = 0; > > -module_param(dbg, bool, 0644); > > -#endif > > - > >  #define PTE_PREFETCH_NUM 8 > >   > > > >  #define PT32_LEVEL_BITS 10 > > @@ -844,17 +83

Re: [PATCH] KVM: x86/mmu: Add '__func__' in rmap_printk()

2021-01-27 Thread Paolo Bonzini
On 27/01/21 18:25, Joe Perches wrote: -#ifdef MMU_DEBUG -bool dbg = 0; -module_param(dbg, bool, 0644); -#endif - #define PTE_PREFETCH_NUM 8 #define PT32_LEVEL_BITS 10 @@ -844,17 +839,17 @@ static int pte_list_add(struct kvm_vcpu *vcpu, u64 *spte, int i, count = 0;

Re: [PATCH] KVM: x86/mmu: Add '__func__' in rmap_printk()

2021-01-27 Thread Joe Perches
On Wed, 2021-01-27 at 11:54 +0100, Paolo Bonzini wrote: > On 27/01/21 03:08, Stephen Zhang wrote: > > Given the common pattern: > > > > rmap_printk("%s:"..., __func__,...) > > > > we could improve this by adding '__func__' in rmap_printk(). Currently, the MMU_DEBUG control is not defined so this

Re: [PATCH] KVM: x86/mmu: Add '__func__' in rmap_printk()

2021-01-27 Thread Paolo Bonzini
On 27/01/21 03:08, Stephen Zhang wrote: Given the common pattern: rmap_printk("%s:"..., __func__,...) we could improve this by adding '__func__' in rmap_printk(). Signed-off-by: Stephen Zhang --- arch/x86/kvm/mmu/mmu.c | 20 ++-- arch/x86/kvm/mmu/mmu_internal.h |

[PATCH] KVM: x86/mmu: Add '__func__' in rmap_printk()

2021-01-26 Thread Stephen Zhang
Given the common pattern: rmap_printk("%s:"..., __func__,...) we could improve this by adding '__func__' in rmap_printk(). Signed-off-by: Stephen Zhang --- arch/x86/kvm/mmu/mmu.c | 20 ++-- arch/x86/kvm/mmu/mmu_internal.h | 2 +- 2 files changed, 11 insertions(+), 11