Re: [PATCH] KVM: x86: compile out TDP MMU on 32-bit systems

2021-02-08 Thread Paolo Bonzini
On 08/02/21 20:26, Sean Christopherson wrote: This can/should also expand the #ifdef to the TDP-only fields in kvm_mmu_page. I also vote to #ifdef out all of tdp_iter.h, and probably the TDP-only fields in struct kvm_arch. Agreed except for tdp_iter.h, I don't see the point since it is not us

Re: [PATCH] KVM: x86: compile out TDP MMU on 32-bit systems

2021-02-08 Thread Sean Christopherson
On Sat, Feb 06, 2021, Paolo Bonzini wrote: > The TDP MMU assumes that it can do atomic accesses to 64-bit PTEs. > Rather than just disabling it, compile it out completely so that it > is possible to use for example 64-bit xchg. > > To limit the number of stubs, wrap all accesses to tdp_mmu_enabled

[PATCH] KVM: x86: compile out TDP MMU on 32-bit systems

2021-02-06 Thread Paolo Bonzini
The TDP MMU assumes that it can do atomic accesses to 64-bit PTEs. Rather than just disabling it, compile it out completely so that it is possible to use for example 64-bit xchg. To limit the number of stubs, wrap all accesses to tdp_mmu_enabled or tdp_mmu_page with a function. Calls to all other