Re: [PATCH] KVM: x86: extend usage of RET_MMIO_PF_* constants

2017-10-10 Thread Paolo Bonzini
On 10/10/2017 21:16, Radim Krčmář wrote: >> -return 0; >> +return RET_PF_EMULATE; > A direct conversion would return RET_PF_RETRY, is this some > optimization? No, it's not (and should be a different patch anyway). Fixed. Paolo

Re: [PATCH] KVM: x86: extend usage of RET_MMIO_PF_* constants

2017-10-10 Thread Radim Krčmář
2017-10-10 11:10+0200, Paolo Bonzini: > The x86 MMU if full of code that returns 0 and 1 for retry/emulate. Use > the existing RET_MMIO_PF_RETRY/RET_MMIO_PF_EMULATE enum, renaming it to > drop the MMIO part. > > Signed-off-by: Paolo Bonzini > --- > diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/

[PATCH] KVM: x86: extend usage of RET_MMIO_PF_* constants

2017-10-10 Thread Paolo Bonzini
The x86 MMU if full of code that returns 0 and 1 for retry/emulate. Use the existing RET_MMIO_PF_RETRY/RET_MMIO_PF_EMULATE enum, renaming it to drop the MMIO part. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/mmu.c | 95 ++ arch/x86/kvm/pagin