Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-17 Thread James Hogan
On 17/04/13 05:13, Vineet Gupta wrote: > Hi James, > > On 04/16/2013 09:23 PM, James Hogan wrote: >> On 12/04/13 22:52, Stephen Warren wrote: >>> +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S >> Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, >> since it'll have quotes around it,

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-17 Thread James Hogan
On 17/04/13 05:13, Vineet Gupta wrote: Hi James, On 04/16/2013 09:23 PM, James Hogan wrote: On 12/04/13 22:52, Stephen Warren wrote: +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, since it'll have quotes around it, so you may

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-16 Thread Vineet Gupta
On 04/16/2013 09:32 PM, James Hogan wrote: > > Also, I think you probably now want *.dtb.S added to clean-files, > otherwise they won't get removed by make clean. Good catch ! Thx, -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-16 Thread Vineet Gupta
Hi James, On 04/16/2013 09:23 PM, James Hogan wrote: > On 12/04/13 22:52, Stephen Warren wrote: >> +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S > Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, > since it'll have quotes around it, so you may instead need: > .SECONDARY:

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-16 Thread James Hogan
On 16/04/13 16:53, James Hogan wrote: > On 12/04/13 22:52, Stephen Warren wrote: >> +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S > > Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, > since it'll have quotes around it, so you may instead need: > .SECONDARY: $(obj)/$(patsubst

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-16 Thread James Hogan
On 12/04/13 22:52, Stephen Warren wrote: > +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, since it'll have quotes around it, so you may instead need: .SECONDARY: $(obj)/$(patsubst "%",%,$(builtindtb-y)).dtb.S (at least that's what's

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-16 Thread James Hogan
On 12/04/13 22:52, Stephen Warren wrote: +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, since it'll have quotes around it, so you may instead need: .SECONDARY: $(obj)/$(patsubst %,%,$(builtindtb-y)).dtb.S (at least that's what's

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-16 Thread James Hogan
On 16/04/13 16:53, James Hogan wrote: On 12/04/13 22:52, Stephen Warren wrote: +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, since it'll have quotes around it, so you may instead need: .SECONDARY: $(obj)/$(patsubst

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-16 Thread Vineet Gupta
Hi James, On 04/16/2013 09:23 PM, James Hogan wrote: On 12/04/13 22:52, Stephen Warren wrote: +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, since it'll have quotes around it, so you may instead need: .SECONDARY:

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-16 Thread Vineet Gupta
On 04/16/2013 09:32 PM, James Hogan wrote: Also, I think you probably now want *.dtb.S added to clean-files, otherwise they won't get removed by make clean. Good catch ! Thx, -Vineet -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-15 Thread Stephen Warren
On 04/15/2013 07:59 AM, Vineet Gupta wrote: > On 04/13/2013 03:22 AM, Stephen Warren wrote: >> >> After installing the ARC toolchain (which was a bit painful to track >> down and install...) > > Sorry about that - we have a buildroot based distro about to be pushed > upstream - > that would

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-15 Thread Vineet Gupta
On 04/13/2013 03:22 AM, Stephen Warren wrote: > > After installing the ARC toolchain (which was a bit painful to track > down and install...) Sorry about that - we have a buildroot based distro about to be pushed upstream - that would make it easier. > I reproduced your exact problem. I

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-15 Thread Vineet Gupta
On 04/13/2013 03:22 AM, Stephen Warren wrote: After installing the ARC toolchain (which was a bit painful to track down and install...) Sorry about that - we have a buildroot based distro about to be pushed upstream - that would make it easier. I reproduced your exact problem. I believe

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-15 Thread Stephen Warren
On 04/15/2013 07:59 AM, Vineet Gupta wrote: On 04/13/2013 03:22 AM, Stephen Warren wrote: After installing the ARC toolchain (which was a bit painful to track down and install...) Sorry about that - we have a buildroot based distro about to be pushed upstream - that would make it

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-12 Thread Stephen Warren
On 04/12/2013 01:40 AM, Vineet Gupta wrote: > On 04/09/2013 07:40 PM, Vineet Gupta wrote: >> On 04/04/2013 11:06 PM, Stephen Warren wrote: >> >>> +.SECONDARY: $(obj)/%.dtb.S >>> + >>> $(obj)/%.dtb.S: $(obj)/%.dtb >>> $(call cmd,dt_S_dtb) >>> >>> and no longer see make rm'ing the .dtb.S

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-12 Thread Vineet Gupta
On 04/09/2013 07:40 PM, Vineet Gupta wrote: > On 04/04/2013 11:06 PM, Stephen Warren wrote: > >> +.SECONDARY: $(obj)/%.dtb.S >> + >> $(obj)/%.dtb.S: $(obj)/%.dtb >> $(call cmd,dt_S_dtb) >> >> and no longer see make rm'ing the .dtb.S file. So, the .SECONDARY is >> behaving as expected, and

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-12 Thread Vineet Gupta
On 04/09/2013 07:40 PM, Vineet Gupta wrote: On 04/04/2013 11:06 PM, Stephen Warren wrote: +.SECONDARY: $(obj)/%.dtb.S + $(obj)/%.dtb.S: $(obj)/%.dtb $(call cmd,dt_S_dtb) and no longer see make rm'ing the .dtb.S file. So, the .SECONDARY is behaving as expected, and should fix your

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-12 Thread Stephen Warren
On 04/12/2013 01:40 AM, Vineet Gupta wrote: On 04/09/2013 07:40 PM, Vineet Gupta wrote: On 04/04/2013 11:06 PM, Stephen Warren wrote: +.SECONDARY: $(obj)/%.dtb.S + $(obj)/%.dtb.S: $(obj)/%.dtb $(call cmd,dt_S_dtb) and no longer see make rm'ing the .dtb.S file. So, the .SECONDARY

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-09 Thread Vineet Gupta
On 04/04/2013 11:06 PM, Stephen Warren wrote: > +.SECONDARY: $(obj)/%.dtb.S > + > $(obj)/%.dtb.S: $(obj)/%.dtb > $(call cmd,dt_S_dtb) > > and no longer see make rm'ing the .dtb.S file. So, the .SECONDARY is > behaving as expected, and should fix your problem. Interestingly, if I make

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-09 Thread Vineet Gupta
On 04/04/2013 11:06 PM, Stephen Warren wrote: > >> Technically .SECONDARY is better - however it doesn't seem to work. > Hmmm. It does for me. > > $ make --version > GNU Make 3.81 Same tools here ! $ make -v GNU Make 3.81 > I hacked the ARM makefiles as follows: > > diff --git

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-09 Thread Vineet Gupta
On 04/04/2013 11:06 PM, Stephen Warren wrote: Technically .SECONDARY is better - however it doesn't seem to work. Hmmm. It does for me. $ make --version GNU Make 3.81 Same tools here ! $ make -v GNU Make 3.81 I hacked the ARM makefiles as follows: diff --git a/arch/arm/Makefile

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-09 Thread Vineet Gupta
On 04/04/2013 11:06 PM, Stephen Warren wrote: +.SECONDARY: $(obj)/%.dtb.S + $(obj)/%.dtb.S: $(obj)/%.dtb $(call cmd,dt_S_dtb) and no longer see make rm'ing the .dtb.S file. So, the .SECONDARY is behaving as expected, and should fix your problem. Interestingly, if I make the file

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-04 Thread Stephen Warren
On 04/03/2013 11:30 PM, Vineet Gupta wrote: > On 04/03/2013 09:48 PM, Stephen Warren wrote: >> On 04/03/2013 01:14 AM, Vineet Gupta wrote: >>> forgot to CC linux-arch >>> >>> On 04/03/2013 12:42 PM, Vineet Gupta wrote: Currently, for every ARC kernel build I see the following:

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-04 Thread Stephen Warren
On 04/03/2013 11:30 PM, Vineet Gupta wrote: On 04/03/2013 09:48 PM, Stephen Warren wrote: On 04/03/2013 01:14 AM, Vineet Gupta wrote: forgot to CC linux-arch On 04/03/2013 12:42 PM, Vineet Gupta wrote: Currently, for every ARC kernel build I see the following:

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-03 Thread Vineet Gupta
On 04/03/2013 09:48 PM, Stephen Warren wrote: > On 04/03/2013 01:14 AM, Vineet Gupta wrote: >> forgot to CC linux-arch >> >> On 04/03/2013 12:42 PM, Vineet Gupta wrote: >>> Currently, for every ARC kernel build I see the following: >>> >>> --->8- >>> DTB

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-03 Thread Stephen Warren
On 04/03/2013 01:14 AM, Vineet Gupta wrote: > forgot to CC linux-arch > > On 04/03/2013 12:42 PM, Vineet Gupta wrote: >> Currently, for every ARC kernel build I see the following: >> >> --->8- >> DTBarch/arc/boot/dts/angel4.dtb.S >> AS

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-03 Thread Vineet Gupta
forgot to CC linux-arch On 04/03/2013 12:42 PM, Vineet Gupta wrote: > Currently, for every ARC kernel build I see the following: > > --->8- > DTBarch/arc/boot/dts/angel4.dtb.S > AS arch/arc/boot/dts/angel4.dtb.o > LD arch/arc/boot/dts/built-in.o >

[PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-03 Thread Vineet Gupta
Currently, for every ARC kernel build I see the following: --->8- DTBarch/arc/boot/dts/angel4.dtb.S AS arch/arc/boot/dts/angel4.dtb.o LD arch/arc/boot/dts/built-in.o rm arch/arc/boot/dts/angel4.dtb.S<-- forces rebuild next iter CHK

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-03 Thread Vineet Gupta
On 04/03/2013 09:48 PM, Stephen Warren wrote: On 04/03/2013 01:14 AM, Vineet Gupta wrote: forgot to CC linux-arch On 04/03/2013 12:42 PM, Vineet Gupta wrote: Currently, for every ARC kernel build I see the following: ---8- DTBarch/arc/boot/dts/angel4.dtb.S

[PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-03 Thread Vineet Gupta
Currently, for every ARC kernel build I see the following: ---8- DTBarch/arc/boot/dts/angel4.dtb.S AS arch/arc/boot/dts/angel4.dtb.o LD arch/arc/boot/dts/built-in.o rm arch/arc/boot/dts/angel4.dtb.S-- forces rebuild next iter CHK

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-03 Thread Vineet Gupta
forgot to CC linux-arch On 04/03/2013 12:42 PM, Vineet Gupta wrote: Currently, for every ARC kernel build I see the following: ---8- DTBarch/arc/boot/dts/angel4.dtb.S AS arch/arc/boot/dts/angel4.dtb.o LD arch/arc/boot/dts/built-in.o rm

Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

2013-04-03 Thread Stephen Warren
On 04/03/2013 01:14 AM, Vineet Gupta wrote: forgot to CC linux-arch On 04/03/2013 12:42 PM, Vineet Gupta wrote: Currently, for every ARC kernel build I see the following: ---8- DTBarch/arc/boot/dts/angel4.dtb.S AS arch/arc/boot/dts/angel4.dtb.o