RE: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-15 Thread Anaczkowski, Lukasz
From: Dave Hansen [mailto:dave.han...@linux.intel.com] Sent: Tuesday, June 14, 2016 7:20 PM >> diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h ... >> +extern void fix_pte_leak(struct mm_struct *mm, unsigned long addr, >> + pte_t *ptep); > Doesn't

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Nadav Amit
Dave Hansen wrote: > On 06/14/2016 01:16 PM, Nadav Amit wrote: >> Dave Hansen wrote: >> >>> On 06/14/2016 09:47 AM, Nadav Amit wrote: Lukasz Anaczkowski wrote: >> From: Andi Kleen >> +void fix_pte_leak(struct mm_struct *mm, unsigned long addr, pte_t *ptep) >> +{ He

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Andy Lutomirski
On Tue, Jun 14, 2016 at 7:44 PM, Nadav Amit wrote: > Andy Lutomirski wrote: > >> On Tue, Jun 14, 2016 at 7:35 PM, Nadav Amit wrote: >>> Andy Lutomirski wrote: >>> On Tue, Jun 14, 2016 at 2:37 PM, Dave Hansen wrote: > On 06/14/2016 01:16 PM, Nadav Amit wrote: >> Dave Hansen w

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Nadav Amit
Andy Lutomirski wrote: > On Tue, Jun 14, 2016 at 7:35 PM, Nadav Amit wrote: >> Andy Lutomirski wrote: >> >>> On Tue, Jun 14, 2016 at 2:37 PM, Dave Hansen >>> wrote: On 06/14/2016 01:16 PM, Nadav Amit wrote: > Dave Hansen wrote: > >> On 06/14/2016 09:47 AM, Nadav Amit wrote:

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Andy Lutomirski
On Tue, Jun 14, 2016 at 7:35 PM, Nadav Amit wrote: > Andy Lutomirski wrote: > >> On Tue, Jun 14, 2016 at 2:37 PM, Dave Hansen >> wrote: >>> On 06/14/2016 01:16 PM, Nadav Amit wrote: Dave Hansen wrote: > On 06/14/2016 09:47 AM, Nadav Amit wrote: >> Lukasz Anaczkowski wrote: >>

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Nadav Amit
Andy Lutomirski wrote: > On Tue, Jun 14, 2016 at 2:37 PM, Dave Hansen > wrote: >> On 06/14/2016 01:16 PM, Nadav Amit wrote: >>> Dave Hansen wrote: >>> On 06/14/2016 09:47 AM, Nadav Amit wrote: > Lukasz Anaczkowski wrote: > >>> From: Andi Kleen >>> +void fix_pte_leak(str

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Andy Lutomirski
On Tue, Jun 14, 2016 at 2:37 PM, Dave Hansen wrote: > On 06/14/2016 01:16 PM, Nadav Amit wrote: >> Dave Hansen wrote: >> >>> On 06/14/2016 09:47 AM, Nadav Amit wrote: Lukasz Anaczkowski wrote: >> From: Andi Kleen >> +void fix_pte_leak(struct mm_struct *mm, unsigned long addr,

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Dave Hansen
On 06/14/2016 01:16 PM, Nadav Amit wrote: > Dave Hansen wrote: > >> On 06/14/2016 09:47 AM, Nadav Amit wrote: >>> Lukasz Anaczkowski wrote: >>> > From: Andi Kleen > +void fix_pte_leak(struct mm_struct *mm, unsigned long addr, pte_t *ptep) > +{ >>> Here there should be a call to smp_

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Nadav Amit
Dave Hansen wrote: > On 06/14/2016 09:47 AM, Nadav Amit wrote: >> Lukasz Anaczkowski wrote: >> From: Andi Kleen +void fix_pte_leak(struct mm_struct *mm, unsigned long addr, pte_t *ptep) +{ >> Here there should be a call to smp_mb__after_atomic() to synchronize with >> switch_mm.

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread kbuild test robot
Hi, [auto build test ERROR on v4.7-rc3] [also build test ERROR on next-20160614] [cannot apply to tip/x86/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Lukasz-Anaczkowski/Linux-VM-workaro

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Dave Hansen
... > +extern void fix_pte_leak(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep); > + > static inline pte_t huge_ptep_get_and_clear(struct mm_struct *mm, > unsigned long addr, pte_t *ptep) > { > - return ptep_get_and_cle

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Dave Hansen
On 06/14/2016 09:47 AM, Nadav Amit wrote: > Lukasz Anaczkowski wrote: > >> > From: Andi Kleen >> > +void fix_pte_leak(struct mm_struct *mm, unsigned long addr, pte_t *ptep) >> > +{ > Here there should be a call to smp_mb__after_atomic() to synchronize with > switch_mm. I submitted a similar patc

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread kbuild test robot
Hi, [auto build test ERROR on v4.7-rc3] [also build test ERROR on next-20160614] [cannot apply to tip/x86/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Lukasz-Anaczkowski/Linux-VM-workaro

RE: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Anaczkowski, Lukasz
From: Nadav Amit [mailto:nadav.a...@gmail.com] Sent: Tuesday, June 14, 2016 6:48 PM > Lukasz Anaczkowski wrote: >> From: Andi Kleen >> +void fix_pte_leak(struct mm_struct *mm, unsigned long addr, pte_t *ptep) >> +{ > Here there should be a call to smp_mb__after_atomic() to synchronize with > s

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Nadav Amit
Lukasz Anaczkowski wrote: > From: Andi Kleen > +void fix_pte_leak(struct mm_struct *mm, unsigned long addr, pte_t *ptep) > +{ Here there should be a call to smp_mb__after_atomic() to synchronize with switch_mm. I submitted a similar patch, which is still pending (hint). > + if (cpumask_any

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread kbuild test robot
Hi, [auto build test ERROR on v4.7-rc3] [also build test ERROR on next-20160614] [cannot apply to tip/x86/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Lukasz-Anaczkowski/Linux-VM-workaro

[PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Lukasz Anaczkowski
From: Andi Kleen Knights Landing has a issue that a thread setting A or D bits may not do so atomically against checking the present bit. A thread which is going to page fault may still set those bits, even though the present bit was already atomically cleared. This implies that when the kernel