RE: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-21 Thread Luck, Tony
> sed -i -e 's/\(INTEL_FAM6_.*\)_MOBILE/\1_ULT/g' ${i} I think it would be better to change the one _ULT to _MOBILE, rather than all the _MOBILE to _ULT -Tony

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-20 Thread Peter Zijlstra
On Thu, Aug 15, 2019 at 10:22:07PM +0200, Thomas Gleixner wrote: > We have the following existing _SHORT variants: > > _G > _EP > _EX > _CORE > _ULT > _GT3E > _XEON_D > _MOBILE > _DESKTOP > _NNPI > _MID > _TABLET > _PLUS Your list is missing: _L and _X. _X is the generic 'server' And we have

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-20 Thread Peter Zijlstra
On Tue, Aug 20, 2019 at 05:40:11PM +0200, Peter Zijlstra wrote: > > _ULT > > _MOBILE > > I suspect these two are the same. for i in `git grep -l "INTEL_FAM6_.*_MOBILE"` do sed -i -e 's/\(INTEL_FAM6_.*\)_MOBILE/\1_ULT/g' ${i} done --- arch/x86/events/intel/core.c | 16

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-20 Thread Peter Zijlstra
On Tue, Aug 20, 2019 at 05:40:11PM +0200, Peter Zijlstra wrote: > > _CORE > > _DESKTOP > > These two and no _SHORT should/could be collated, I think. for i in `git grep -l "INTEL_FAM6_.*_\(CORE\|DESKTOP\)"` do sed -i -e 's/\(INTEL_FAM6_.*\)_\(CORE\|DESKTOP\)/\1/g' ${i} done ---

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-20 Thread Peter Zijlstra
On Thu, Aug 15, 2019 at 10:22:07PM +0200, Thomas Gleixner wrote: > We have the following existing _SHORT variants: > _G > _GT3E Those two are special SOCs due to 'extra graphics bits on', and I suppose we could collate them. That said; I'm not sure NHM_G ever shipped, I'm looking at a wikipedia

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-20 Thread Peter Zijlstra
On Thu, Aug 15, 2019 at 10:22:07PM +0200, Thomas Gleixner wrote: > On Thu, 15 Aug 2019, Luck, Tony wrote: > > On Thu, Aug 15, 2019 at 07:54:55PM +0200, Borislav Petkov wrote: > > @@ -11,6 +11,21 @@ > > * While adding a new CPUID for a new microarchitecture, add a new > > * group to keep

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-16 Thread Borislav Petkov
On Fri, Aug 16, 2019 at 04:29:19PM +, Luck, Tony wrote: > >> + * The defined symbol names have the following form: > >> + *INTEL_FAM6{OPTFAMILY}_{MICROARCH}{OPTDIFF} > > > > I think you want to have the underscores in the template: > > > >

RE: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-16 Thread David Laight
From: Luck, Tony > Sent: 16 August 2019 17:29 > >> + * The defined symbol names have the following form: > >> + *INTEL_FAM6{OPTFAMILY}_{MICROARCH}{OPTDIFF} > > > > I think you want to have the underscores in the template: > > > > INTEL_FAM6_{OPTFAMILY}_{MICROARCH}_{OPTDIFF} > > > > but

RE: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-16 Thread Luck, Tony
>> + * The defined symbol names have the following form: >> + * INTEL_FAM6{OPTFAMILY}_{MICROARCH}{OPTDIFF} > > I think you want to have the underscores in the template: > > INTEL_FAM6_{OPTFAMILY}_{MICROARCH}_{OPTDIFF} > > but no need to resend if this is the only issue - I'll fix it up when

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-16 Thread Thomas Gleixner
On Thu, 15 Aug 2019, Luck, Tony wrote: > >From 093bf8cd02f4c7a3fa256c2cf7302014190e2840 Mon Sep 17 00:00:00 2001 > From: Tony Luck > Date: Thu, 15 Aug 2019 11:16:24 -0700 > Subject: [PATCH] x86/cpu: Explain Intel model naming convention > > Dave Hansen spelled out the rules in an e-mail: > >

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-16 Thread Borislav Petkov
On Thu, Aug 15, 2019 at 03:47:05PM -0700, Luck, Tony wrote: > On Thu, Aug 15, 2019 at 10:22:07PM +0200, Thomas Gleixner wrote: > > On Thu, 15 Aug 2019, Luck, Tony wrote: > > > On Thu, Aug 15, 2019 at 07:54:55PM +0200, Borislav Petkov wrote: > > So we should document the list of valid and usable

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-15 Thread Luck, Tony
On Thu, Aug 15, 2019 at 10:22:07PM +0200, Thomas Gleixner wrote: > On Thu, 15 Aug 2019, Luck, Tony wrote: > > On Thu, Aug 15, 2019 at 07:54:55PM +0200, Borislav Petkov wrote: > So we should document the list of valid and usable ones and either fixup > broken ones or document that they are historic

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-15 Thread Thomas Gleixner
On Thu, 15 Aug 2019, Luck, Tony wrote: > On Thu, Aug 15, 2019 at 07:54:55PM +0200, Borislav Petkov wrote: > @@ -11,6 +11,21 @@ > * While adding a new CPUID for a new microarchitecture, add a new > * group to keep logically sorted out in chronological order. Within > * that group keep the

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-15 Thread Borislav Petkov
On Thu, Aug 15, 2019 at 11:30:55AM -0700, Luck, Tony wrote: > On Thu, Aug 15, 2019 at 07:54:55PM +0200, Borislav Petkov wrote: > > On Thu, Aug 15, 2019 at 10:21:59AM -0700, Luck, Tony wrote: > > > Like this? > > > > Actually, I was thinking you'd put it above the defines in the file > >

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-15 Thread Luck, Tony
On Thu, Aug 15, 2019 at 07:54:55PM +0200, Borislav Petkov wrote: > On Thu, Aug 15, 2019 at 10:21:59AM -0700, Luck, Tony wrote: > > Like this? > > Actually, I was thinking you'd put it above the defines in the file > intel-family.h itself so that *everyone* who wants to add a model, sees > it

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-15 Thread Borislav Petkov
On Thu, Aug 15, 2019 at 10:21:59AM -0700, Luck, Tony wrote: > Like this? Actually, I was thinking you'd put it above the defines in the file intel-family.h itself so that *everyone* who wants to add a model, sees it first and while that explanation below is very nice... > +The CPU model number

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-15 Thread Luck, Tony
On Thu, Aug 15, 2019 at 09:58:22AM +0200, Borislav Petkov wrote: > On Wed, Aug 14, 2019 at 04:40:30PM -0700, Tony Luck wrote: > > There are a few different subsystems in the kernel that depend on > > model specific behaviour (perf, EDAC, power, ...). Easier for just > > one person to have the task

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-15 Thread Borislav Petkov
On Wed, Aug 14, 2019 at 04:40:30PM -0700, Tony Luck wrote: > There are a few different subsystems in the kernel that depend on > model specific behaviour (perf, EDAC, power, ...). Easier for just > one person to have the task to get new model numbers included instead > of having these groups trip

[PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-14 Thread Tony Luck
There are a few different subsystems in the kernel that depend on model specific behaviour (perf, EDAC, power, ...). Easier for just one person to have the task to get new model numbers included instead of having these groups trip over each other to do it. Signed-off-by: Tony Luck ---