Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-12-17 Thread Brian Norris
On Tue, Nov 26, 2013 at 07:35:55PM -0800, Brian Norris wrote: > On Wed, Nov 27, 2013 at 09:14:18AM +0900, Jingoo Han wrote: > > On Wednesday, November 27, 2013 8:50 AM, Brian Norris wrote: > > > On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: > > > > --- a/drivers/mtd/nand/au1550nd.c

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-12-17 Thread Brian Norris
On Tue, Nov 26, 2013 at 07:35:55PM -0800, Brian Norris wrote: On Wed, Nov 27, 2013 at 09:14:18AM +0900, Jingoo Han wrote: On Wednesday, November 27, 2013 8:50 AM, Brian Norris wrote: On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: --- a/drivers/mtd/nand/au1550nd.c +++

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-26 Thread Brian Norris
Hi Jingoo, On Wed, Nov 27, 2013 at 09:14:18AM +0900, Jingoo Han wrote: > On Wednesday, November 27, 2013 8:50 AM, Brian Norris wrote: > > On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: > > > From: Wei Yongjun > > > > > > Add missing platform_set_drvdata() in au1550nd_probe(),

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-26 Thread Jingoo Han
On Wednesday, November 27, 2013 8:50 AM, Brian Norris wrote: Hi Brian Norris, I added my questions as below. :-) > On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > > > Add missing platform_set_drvdata() in au1550nd_probe(), otherwise > > calling

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-26 Thread Brian Norris
On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Add missing platform_set_drvdata() in au1550nd_probe(), otherwise > calling platform_get_drvdata() in remove returns NULL. An alternative solution: just allocate ctx with devm_kzalloc(). Then you don't have to

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-26 Thread Brian Norris
On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add missing platform_set_drvdata() in au1550nd_probe(), otherwise calling platform_get_drvdata() in remove returns NULL. An alternative solution: just allocate ctx with

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-26 Thread Jingoo Han
On Wednesday, November 27, 2013 8:50 AM, Brian Norris wrote: Hi Brian Norris, I added my questions as below. :-) On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add missing platform_set_drvdata() in au1550nd_probe(), otherwise

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-26 Thread Brian Norris
Hi Jingoo, On Wed, Nov 27, 2013 at 09:14:18AM +0900, Jingoo Han wrote: On Wednesday, November 27, 2013 8:50 AM, Brian Norris wrote: On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add missing platform_set_drvdata() in

[PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-10 Thread Wei Yongjun
From: Wei Yongjun Add missing platform_set_drvdata() in au1550nd_probe(), otherwise calling platform_get_drvdata() in remove returns NULL. Signed-off-by: Wei Yongjun --- drivers/mtd/nand/au1550nd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/au1550nd.c

[PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-10 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Add missing platform_set_drvdata() in au1550nd_probe(), otherwise calling platform_get_drvdata() in remove returns NULL. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/mtd/nand/au1550nd.c | 2 ++ 1 file changed, 2