Re: [PATCH] MIPS: Enable interrupts in arch_cpu_idle()

2013-05-02 Thread Linus Torvalds
On Thu, May 2, 2013 at 7:58 AM, Ralf Baechle wrote: > > For a while we just used to live with the race condition resulting from > not disabling interrupts in the idle loop. Then c65a5480 fixed this by > checking if we're returning to the WAIT instruction in the idle loop > when returning from an

Re: [PATCH] MIPS: Enable interrupts in arch_cpu_idle()

2013-05-02 Thread Ralf Baechle
On Thu, May 02, 2013 at 04:33:52PM +0200, Thomas Gleixner wrote: > commit cdbedc61c8 (mips: Use generic idle loop) broke MIPS as I did > not realize that MIPS wants to invoke the wait instructions with > interrupts enabled. Don't ask why that works correctly; Ralf suggested > to get thoroughly dru

[PATCH] MIPS: Enable interrupts in arch_cpu_idle()

2013-05-02 Thread Thomas Gleixner
commit cdbedc61c8 (mips: Use generic idle loop) broke MIPS as I did not realize that MIPS wants to invoke the wait instructions with interrupts enabled. Don't ask why that works correctly; Ralf suggested to get thoroughly drunk before even thinking about it. Looking sober at commit c65a5480 ([MIPS]