Re: [PATCH] MIPS: Fix incorrect NULL check in local_flush_tlb_page()

2014-07-04 Thread Emil Goode
Hello Jonas, On Fri, Jul 04, 2014 at 11:52:51PM +0200, Jonas Gorski wrote: > On Fri, Jul 4, 2014 at 7:07 PM, Emil Goode wrote: > > We check that the struct vm_area_struct pointer vma is NULL and > > then dereference it. The intent must have been to check that > > vma is not NULL before we derefer

Re: [PATCH] MIPS: Fix incorrect NULL check in local_flush_tlb_page()

2014-07-04 Thread Jonas Gorski
On Fri, Jul 4, 2014 at 7:07 PM, Emil Goode wrote: > We check that the struct vm_area_struct pointer vma is NULL and > then dereference it. The intent must have been to check that > vma is not NULL before we dereference it in the next condition. Actually if it is NULL, then it will short-cut and w

[PATCH] MIPS: Fix incorrect NULL check in local_flush_tlb_page()

2014-07-04 Thread Emil Goode
We check that the struct vm_area_struct pointer vma is NULL and then dereference it. The intent must have been to check that vma is not NULL before we dereference it in the next condition. Signed-off-by: Emil Goode --- arch/mips/mm/tlb-r3k.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(