Re: [PATCH] MIPS: SGI-IP27: Fix use of unchecked pointer in shutdown_bridge_irq

2019-03-28 Thread Paul Burton
Hello, Thomas Bogendoerfer wrote: > smatch complaint: > > arch/mips/sgi-ip27/ip27-irq.c:123 shutdown_bridge_irq() > warn: variable dereferenced before check 'hd' (see line 121) > > Fix it by removing local variable and use hd->pin directly. > > Fixes: 69a07a41d908 ("MIPS: SGI-IP27: rework HUB i

Re: [PATCH] MIPS: SGI-IP27: Fix use of unchecked pointer in shutdown_bridge_irq

2019-03-28 Thread Mukesh Ojha
On 3/28/2019 7:07 PM, Thomas Bogendoerfer wrote: smatch complaint: arch/mips/sgi-ip27/ip27-irq.c:123 shutdown_bridge_irq() warn: variable dereferenced before check 'hd' (see line 121) Fix it by removing local variable and use hd->pin directly. Fixes: 69a07a41d908 ("MIPS: SGI-IP27:

[PATCH] MIPS: SGI-IP27: Fix use of unchecked pointer in shutdown_bridge_irq

2019-03-28 Thread Thomas Bogendoerfer
smatch complaint: arch/mips/sgi-ip27/ip27-irq.c:123 shutdown_bridge_irq() warn: variable dereferenced before check 'hd' (see line 121) Fix it by removing local variable and use hd->pin directly. Fixes: 69a07a41d908 ("MIPS: SGI-IP27: rework HUB interrupts") Reported-by: Dan Carpenter Sig