Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-27 Thread Ralf Baechle
On Fri, May 23, 2014 at 11:37:01PM +0200, Andreas Herrmann wrote: > > void __init smp_cpus_done(unsigned int max_cpus) > > { > > - mp_ops->cpus_done(); > > + if (cpus_done) > > + mp_ops->cpus_done(); > > } > > > > which would make a NULL cpus_done function pointer safe and allow

Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-27 Thread Ralf Baechle
On Fri, May 23, 2014 at 11:37:01PM +0200, Andreas Herrmann wrote: void __init smp_cpus_done(unsigned int max_cpus) { - mp_ops-cpus_done(); + if (cpus_done) + mp_ops-cpus_done(); } which would make a NULL cpus_done function pointer safe and allow empty definitions

Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-23 Thread Andreas Herrmann
On Thu, May 22, 2014 at 03:26:45PM +0200, Ralf Baechle wrote: > On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote: > > > Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the > > Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these > > checks. > > > > Also

Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-23 Thread Andreas Herrmann
On Thu, May 22, 2014 at 03:26:45PM +0200, Ralf Baechle wrote: On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote: Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these checks. Also remove the last

Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-22 Thread Ralf Baechle
On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote: > Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the > Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these > checks. > > Also remove the last reference to octeon_get_boot_debug_flag(). There is > no

Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-22 Thread Ralf Baechle
On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote: Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these checks. Also remove the last reference to octeon_get_boot_debug_flag(). There is no definition

Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-21 Thread Paul Bolle
On Wed, 2014-05-21 at 22:27 +0200, Andreas Herrmann wrote: > On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote: > > Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the > > Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these > > checks. > > > > Also remove

Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-21 Thread Andreas Herrmann
On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote: > Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the > Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these > checks. > > Also remove the last reference to octeon_get_boot_debug_flag(). There is > no

Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-21 Thread Andreas Herrmann
On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote: Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these checks. Also remove the last reference to octeon_get_boot_debug_flag(). There is no definition of

Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-21 Thread Paul Bolle
On Wed, 2014-05-21 at 22:27 +0200, Andreas Herrmann wrote: On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote: Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these checks. Also remove the last

[PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-20 Thread Paul Bolle
Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these checks. Also remove the last reference to octeon_get_boot_debug_flag(). There is no definition of that function anyway. Signed-off-by: Paul Bolle --- Untested.

[PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

2014-05-20 Thread Paul Bolle
Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these checks. Also remove the last reference to octeon_get_boot_debug_flag(). There is no definition of that function anyway. Signed-off-by: Paul Bolle