Re: [PATCH] MIPS: include: Mark __xchg as __always_inline

2019-10-09 Thread Paul Burton
Hello, Thomas Bogendoerfer wrote: > Commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING > forcibly") allows compiler to uninline functions marked as 'inline'. > In cace of __xchg this would cause to reference function > __xchg_called_with_bad_pointer, which is an error case > for catch

Re: [PATCH] MIPS: include: Mark __xchg as __always_inline

2019-10-09 Thread Philippe Mathieu-Daudé
On 10/9/19 12:06 PM, Thomas Bogendoerfer wrote: Commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING forcibly") allows compiler to uninline functions marked as 'inline'. In cace of __xchg this would cause to reference function Typo: "in case of" __xchg_called_with_bad_pointer, whic

[PATCH] MIPS: include: Mark __xchg as __always_inline

2019-10-09 Thread Thomas Bogendoerfer
Commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING forcibly") allows compiler to uninline functions marked as 'inline'. In cace of __xchg this would cause to reference function __xchg_called_with_bad_pointer, which is an error case for catching bugs and will not happen for correct code