Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-25 Thread Pierre Ossman
Manuel Lauss wrote: > > Apparently my HW is broken... I got a hold of a DB1200 demoboard and > the distributed version works fine there. > > I'm very sorry for the noise! > No problem. Better safe than sorry. > > Aren't people from AMD (now Raza) maintaining it? I have source for this >

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-25 Thread Pierre Ossman
Manuel Lauss wrote: > > Actually, the bug is that because of MMC_RSP_R6 not being handled in > the switch in au1xmmc_send_command(), the controller gets told that > no response is expected. I changed the R6 to R1 in mmc.h, thats why > it worked in the demoboard, and it also works now on the

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-25 Thread Manuel Lauss
Hi Pierre, > > > HEAD has this fixed. Every spec I can get my hands on states that R1 and > > R6 have the same format. So it sounds like this controller is doing > > something stupid. > > Apparently my HW is broken... I got a hold of a DB1200 demoboard and > the distributed version works fine

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-25 Thread Manuel Lauss
Hi Pierre, HEAD has this fixed. Every spec I can get my hands on states that R1 and R6 have the same format. So it sounds like this controller is doing something stupid. Apparently my HW is broken... I got a hold of a DB1200 demoboard and the distributed version works fine there.

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-25 Thread Pierre Ossman
Manuel Lauss wrote: Actually, the bug is that because of MMC_RSP_R6 not being handled in the switch in au1xmmc_send_command(), the controller gets told that no response is expected. I changed the R6 to R1 in mmc.h, thats why it worked in the demoboard, and it also works now on the previously

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-25 Thread Pierre Ossman
Manuel Lauss wrote: Apparently my HW is broken... I got a hold of a DB1200 demoboard and the distributed version works fine there. I'm very sorry for the noise! No problem. Better safe than sorry. Aren't people from AMD (now Raza) maintaining it? I have source for this driver which

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-24 Thread Manuel Lauss
Hi Pierre, > HEAD has this fixed. Every spec I can get my hands on states that R1 and > R6 have the same format. So it sounds like this controller is doing > something stupid. Apparently my HW is broken... I got a hold of a DB1200 demoboard and the distributed version works fine there. I'm very

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-24 Thread Pierre Ossman
Manuel Lauss wrote: > > not in my version of 2.6.20-rc5 (and 2.6.19): > HEAD has this fixed. Every spec I can get my hands on states that R1 and R6 have the same format. So it sounds like this controller is doing something stupid. > > Without the patch, SD card detection stops with CMD7

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-24 Thread Pierre Ossman
Manuel Lauss wrote: not in my version of 2.6.20-rc5 (and 2.6.19): HEAD has this fixed. Every spec I can get my hands on states that R1 and R6 have the same format. So it sounds like this controller is doing something stupid. Without the patch, SD card detection stops with CMD7 returning

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-24 Thread Manuel Lauss
Hi Pierre, HEAD has this fixed. Every spec I can get my hands on states that R1 and R6 have the same format. So it sounds like this controller is doing something stupid. Apparently my HW is broken... I got a hold of a DB1200 demoboard and the distributed version works fine there. I'm very

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-23 Thread Manuel Lauss
On Wed, Jan 24, 2007 at 06:52:02AM +0100, Manuel Lauss wrote: > On Tue, Jan 23, 2007 at 07:56:51PM +0100, Pierre Ossman wrote: > > > here's a trivial patch which adds R6 reponse support to the au1xmmc > > > driver. Fixes SD card detection / operation. > > > > > NAK. MMC_RSP_R1 and MMC_RSP_R6 have

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-23 Thread Manuel Lauss
On Tue, Jan 23, 2007 at 07:56:51PM +0100, Pierre Ossman wrote: > > here's a trivial patch which adds R6 reponse support to the au1xmmc > > driver. Fixes SD card detection / operation. > > > NAK. MMC_RSP_R1 and MMC_RSP_R6 have the same value so this will break > the switch. not in my version of

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-23 Thread Pierre Ossman
Manuel Lauss wrote: > Hi, > > here's a trivial patch which adds R6 reponse support to the au1xmmc > driver. Fixes SD card detection / operation. > NAK. MMC_RSP_R1 and MMC_RSP_R6 have the same value so this will break the switch. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer

[PATCH] MMC: au1xmmc R6 response support

2007-01-23 Thread Manuel Lauss
Hi, here's a trivial patch which adds R6 reponse support to the au1xmmc driver. Fixes SD card detection / operation. --- Add Response type R6 support to the au1xmmc driver; fixes SD card detection and operation. Signed-off-by: Manuel Lauss <[EMAIL PROTECTED]> --- a/drivers/mmc/au1xmmc.c~

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-23 Thread Pierre Ossman
Manuel Lauss wrote: Hi, here's a trivial patch which adds R6 reponse support to the au1xmmc driver. Fixes SD card detection / operation. NAK. MMC_RSP_R1 and MMC_RSP_R6 have the same value so this will break the switch. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-23 Thread Manuel Lauss
On Tue, Jan 23, 2007 at 07:56:51PM +0100, Pierre Ossman wrote: here's a trivial patch which adds R6 reponse support to the au1xmmc driver. Fixes SD card detection / operation. NAK. MMC_RSP_R1 and MMC_RSP_R6 have the same value so this will break the switch. not in my version of

Re: [PATCH] MMC: au1xmmc R6 response support

2007-01-23 Thread Manuel Lauss
On Wed, Jan 24, 2007 at 06:52:02AM +0100, Manuel Lauss wrote: On Tue, Jan 23, 2007 at 07:56:51PM +0100, Pierre Ossman wrote: here's a trivial patch which adds R6 reponse support to the au1xmmc driver. Fixes SD card detection / operation. NAK. MMC_RSP_R1 and MMC_RSP_R6 have the same

[PATCH] MMC: au1xmmc R6 response support

2007-01-23 Thread Manuel Lauss
Hi, here's a trivial patch which adds R6 reponse support to the au1xmmc driver. Fixes SD card detection / operation. --- Add Response type R6 support to the au1xmmc driver; fixes SD card detection and operation. Signed-off-by: Manuel Lauss [EMAIL PROTECTED] --- a/drivers/mmc/au1xmmc.c~