Re: [PATCH] MODSIGN: Move the magic string to the end of a module and eliminate the search

2012-10-24 Thread Rusty Russell
David Howells writes: > Rusty Russell wrote: > >> Meh, I really wanted to separate the module signature locating (my >> problem) from the decoding and checking (your problem). > > You could split mod_verify_sig() at the: > > /* For the moment, only support RSA and X.509 identifiers */ > >

Re: [PATCH] MODSIGN: Move the magic string to the end of a module and eliminate the search

2012-10-24 Thread Rusty Russell
David Howells dhowe...@redhat.com writes: Rusty Russell ru...@rustcorp.com.au wrote: Meh, I really wanted to separate the module signature locating (my problem) from the decoding and checking (your problem). You could split mod_verify_sig() at the: /* For the moment, only support RSA

Re: [PATCH] MODSIGN: Move the magic string to the end of a module and eliminate the search

2012-10-22 Thread David Howells
Rusty Russell wrote: > Meh, I really wanted to separate the module signature locating (my > problem) from the decoding and checking (your problem). You could split mod_verify_sig() at the: /* For the moment, only support RSA and X.509 identifiers */ comment. At that point we have

Re: [PATCH] MODSIGN: Move the magic string to the end of a module and eliminate the search

2012-10-22 Thread David Howells
Rusty Russell ru...@rustcorp.com.au wrote: Meh, I really wanted to separate the module signature locating (my problem) from the decoding and checking (your problem). You could split mod_verify_sig() at the: /* For the moment, only support RSA and X.509 identifiers */ comment. At

Re: [PATCH] MODSIGN: Move the magic string to the end of a module and eliminate the search

2012-10-21 Thread Rusty Russell
David Howells writes: > Emit the magic string that indicates a module has a signature after the > signature data instead of before it. This allows module_sig_check() to be > made simpler and faster by the elimination of the search for the magic string. > Instead we just need to do a single

Re: [PATCH] MODSIGN: Move the magic string to the end of a module and eliminate the search

2012-10-21 Thread Rusty Russell
David Howells dhowe...@redhat.com writes: Emit the magic string that indicates a module has a signature after the signature data instead of before it. This allows module_sig_check() to be made simpler and faster by the elimination of the search for the magic string. Instead we just need to do

[PATCH] MODSIGN: Move the magic string to the end of a module and eliminate the search

2012-10-19 Thread David Howells
Emit the magic string that indicates a module has a signature after the signature data instead of before it. This allows module_sig_check() to be made simpler and faster by the elimination of the search for the magic string. Instead we just need to do a single memcmp(). This works because at the

[PATCH] MODSIGN: Move the magic string to the end of a module and eliminate the search

2012-10-19 Thread David Howells
Emit the magic string that indicates a module has a signature after the signature data instead of before it. This allows module_sig_check() to be made simpler and faster by the elimination of the search for the magic string. Instead we just need to do a single memcmp(). This works because at the