Re: [PATCH] MPC8xx PCMCIA driver

2005-09-01 Thread Marcelo Tosatti
Thu, Sep 01, 2005 at 10:53:19AM +0200, Dominik Brodowski wrote: > Hi, > > On Mon, Aug 29, 2005 at 11:48:40PM -0300, Marcelo Tosatti wrote: > > Russell: The driver is using pccard_nonstatic_ops for card window > > management, even though the driver its marked SS_STATIC_MAP (using > > mem->static_m

Re: [PATCH] MPC8xx PCMCIA driver

2005-09-01 Thread Magnus Damm
Hello all, Nice to see that this driver gets forward ported to 2.6. I originally wrote it for pcmcia-cs, but it made its way into 2.4 after a while. Thanks to all the people who added code and fixes. I'm not sure how the current Linux pcmcia layer works, and I am not involved in powerpc land anym

Re: [PATCH] MPC8xx PCMCIA driver

2005-09-01 Thread Dominik Brodowski
Hi, On Mon, Aug 29, 2005 at 11:48:40PM -0300, Marcelo Tosatti wrote: > Russell: The driver is using pccard_nonstatic_ops for card window > management, even though the driver its marked SS_STATIC_MAP (using > mem->static_map). This is obviously broken. Where does it fail if pccard_static_ops is us

Re: [PATCH] MPC8xx PCMCIA driver

2005-08-30 Thread Marcelo Tosatti
Hi Paul, Jeff, On Tue, Aug 30, 2005 at 02:32:29PM +1000, Paul Mackerras wrote: > Marcelo Tosatti writes: > > > The memory map structure which contains device configuration/registers > > is _always_ directly mapped with pte's (the 8xx is a chip with builtin > > UART/network/etc functionality). > >

Re: [PATCH] MPC8xx PCMCIA driver

2005-08-30 Thread Russell King
On Mon, Aug 29, 2005 at 11:48:40PM -0300, Marcelo Tosatti wrote: > Here goes the 8xx PCMCIA driver, originally written by Magnus Damm, with > several improvements and fixes. Please don't copy me on PCMCIA stuff - I don't look after PCMCIA anymore. Please use the linux-pcmcia mailing list on lists.

Re: [PATCH] MPC8xx PCMCIA driver

2005-08-29 Thread Jeff Garzik
Marcelo Tosatti wrote: On Mon, Aug 29, 2005 at 11:39:02PM -0400, Jeff Garzik wrote: Marcelo Tosatti wrote: +static int voltage_set(int slot, int vcc, int vpp) +{ + u_int reg = 0; + + switch(vcc) { + case 0: break; + case 33: + reg |= BCSR1_PCVCTL4; +

Re: [PATCH] MPC8xx PCMCIA driver

2005-08-29 Thread Paul Mackerras
Marcelo Tosatti writes: > The memory map structure which contains device configuration/registers > is _always_ directly mapped with pte's (the 8xx is a chip with builtin > UART/network/etc functionality). > > I don't think there is a need to use read/write acessors. Generally on PowerPC you need

Re: [PATCH] MPC8xx PCMCIA driver

2005-08-29 Thread Marcelo Tosatti
On Mon, Aug 29, 2005 at 11:39:02PM -0400, Jeff Garzik wrote: > Marcelo Tosatti wrote: > >+static int voltage_set(int slot, int vcc, int vpp) > >+{ > >+u_int reg = 0; > >+ > >+switch(vcc) { > >+case 0: break; > >+case 33: > >+reg |= BCSR1_PCVCTL4; > >+break; >

Re: [PATCH] MPC8xx PCMCIA driver

2005-08-29 Thread Jeff Garzik
Marcelo Tosatti wrote: +static int voltage_set(int slot, int vcc, int vpp) +{ + u_int reg = 0; + + switch(vcc) { + case 0: break; + case 33: + reg |= BCSR1_PCVCTL4; + break; + case 50: + reg |= BCSR1_PCVCTL5; + break; + default:

[PATCH] MPC8xx PCMCIA driver

2005-08-29 Thread Marcelo Tosatti
Hi, Here goes the 8xx PCMCIA driver, originally written by Magnus Damm, with several improvements and fixes. The driver was merged in v2.4 but never forward ported to v2.6. Please review, comments are welcome (including aesthetic enhancements). Russell: The driver is using pccard_nonstatic_ops