Re: [PATCH] Make JFFS2 endianness configurable

2018-11-06 Thread Nikunj Kela (nkela)
Thanks for input. I have posted another patch with mount option: http://lists.infradead.org/pipermail/linux-mtd/2018-November/085252.html On 11/2/18, 2:23 PM, "Richard Weinberger" wrote: Am Freitag, 2. November 2018, 22:14:44 CET schrieb Daniel Walker: > > Make it a mount option and

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-06 Thread Nikunj Kela (nkela)
Thanks for input. I have posted another patch with mount option: http://lists.infradead.org/pipermail/linux-mtd/2018-November/085252.html On 11/2/18, 2:23 PM, "Richard Weinberger" wrote: Am Freitag, 2. November 2018, 22:14:44 CET schrieb Daniel Walker: > > Make it a mount option and

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Richard Weinberger
Am Freitag, 2. November 2018, 22:14:44 CET schrieb Daniel Walker: > > Make it a mount option and store the endianness mode in the super block. > > It's actually a mkfs option currently. I'm not sure how that factors in, > > from the mkfs.jffs2 man page, > >-l, --little-endian >

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Richard Weinberger
Am Freitag, 2. November 2018, 22:14:44 CET schrieb Daniel Walker: > > Make it a mount option and store the endianness mode in the super block. > > It's actually a mkfs option currently. I'm not sure how that factors in, > > from the mkfs.jffs2 man page, > >-l, --little-endian >

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Daniel Walker
On Fri, Nov 02, 2018 at 09:15:06PM +0100, Richard Weinberger wrote: > On Fri, Nov 2, 2018 at 3:04 PM Daniel Walker wrote: > > Do you have any thought on how to implement it ? I was think abstracting the > > endian functions in the nodelist.h > > Yes, see what UFS does. > > > static inline

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Daniel Walker
On Fri, Nov 02, 2018 at 09:15:06PM +0100, Richard Weinberger wrote: > On Fri, Nov 2, 2018 at 3:04 PM Daniel Walker wrote: > > Do you have any thought on how to implement it ? I was think abstracting the > > endian functions in the nodelist.h > > Yes, see what UFS does. > > > static inline

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Richard Weinberger
On Fri, Nov 2, 2018 at 3:04 PM Daniel Walker wrote: > Do you have any thought on how to implement it ? I was think abstracting the > endian functions in the nodelist.h Yes, see what UFS does. > static inline jint16_t cpu_to_je16(jint16_t x) { > if (check_big_endian()) { >

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Richard Weinberger
On Fri, Nov 2, 2018 at 3:04 PM Daniel Walker wrote: > Do you have any thought on how to implement it ? I was think abstracting the > endian functions in the nodelist.h Yes, see what UFS does. > static inline jint16_t cpu_to_je16(jint16_t x) { > if (check_big_endian()) { >

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Daniel Walker
On Fri, Nov 02, 2018 at 12:34:34AM +, Al Viro wrote: > On Thu, Nov 01, 2018 at 05:02:36PM -0700, Daniel Walker wrote: > > > > > > > > On Thu, Nov 01, 2018 at 03:56:03PM -0700, Nikunj Kela wrote: > > > This patch allows the endianness of the JFSS2 filesystem to be > > > specified by config

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Daniel Walker
On Fri, Nov 02, 2018 at 12:34:34AM +, Al Viro wrote: > On Thu, Nov 01, 2018 at 05:02:36PM -0700, Daniel Walker wrote: > > > > > > > > On Thu, Nov 01, 2018 at 03:56:03PM -0700, Nikunj Kela wrote: > > > This patch allows the endianness of the JFSS2 filesystem to be > > > specified by config

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Richard Weinberger
On Fri, Nov 2, 2018 at 9:46 AM Joakim Tjernlund wrote: > > On Thu, 2018-11-01 at 15:56 -0700, Nikunj Kela wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the content is safe. > >

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Richard Weinberger
On Fri, Nov 2, 2018 at 9:46 AM Joakim Tjernlund wrote: > > On Thu, 2018-11-01 at 15:56 -0700, Nikunj Kela wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the content is safe. > >

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Joakim Tjernlund
On Thu, 2018-11-01 at 15:56 -0700, Nikunj Kela wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > This patch allows the endianness of the JFSS2 filesystem to be

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-02 Thread Joakim Tjernlund
On Thu, 2018-11-01 at 15:56 -0700, Nikunj Kela wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > This patch allows the endianness of the JFSS2 filesystem to be

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-01 Thread Al Viro
On Thu, Nov 01, 2018 at 05:02:36PM -0700, Daniel Walker wrote: > > > > On Thu, Nov 01, 2018 at 03:56:03PM -0700, Nikunj Kela wrote: > > This patch allows the endianness of the JFSS2 filesystem to be > > specified by config options. > > > > It defaults to native-endian (the previously

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-01 Thread Al Viro
On Thu, Nov 01, 2018 at 05:02:36PM -0700, Daniel Walker wrote: > > > > On Thu, Nov 01, 2018 at 03:56:03PM -0700, Nikunj Kela wrote: > > This patch allows the endianness of the JFSS2 filesystem to be > > specified by config options. > > > > It defaults to native-endian (the previously

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-01 Thread Daniel Walker
On Thu, Nov 01, 2018 at 03:56:03PM -0700, Nikunj Kela wrote: > This patch allows the endianness of the JFSS2 filesystem to be > specified by config options. > > It defaults to native-endian (the previously hard-coded option). > > Some architectures benefit from having a single known

Re: [PATCH] Make JFFS2 endianness configurable

2018-11-01 Thread Daniel Walker
On Thu, Nov 01, 2018 at 03:56:03PM -0700, Nikunj Kela wrote: > This patch allows the endianness of the JFSS2 filesystem to be > specified by config options. > > It defaults to native-endian (the previously hard-coded option). > > Some architectures benefit from having a single known

[PATCH] Make JFFS2 endianness configurable

2018-11-01 Thread Nikunj Kela
This patch allows the endianness of the JFSS2 filesystem to be specified by config options. It defaults to native-endian (the previously hard-coded option). Some architectures benefit from having a single known endianness of JFFS2 filesystem (for data, not executables) independent of the

[PATCH] Make JFFS2 endianness configurable

2018-11-01 Thread Nikunj Kela
This patch allows the endianness of the JFSS2 filesystem to be specified by config options. It defaults to native-endian (the previously hard-coded option). Some architectures benefit from having a single known endianness of JFFS2 filesystem (for data, not executables) independent of the