Re: [PATCH] Make appletouch shut up when it has nothing to say

2007-05-15 Thread Matthew Garrett
On Tue, May 15, 2007 at 08:34:55PM +, Soeren Sonnenburg wrote: > I was using this patch for some days now and I realized that - from time > to time - the touchpad runs amok, i.e. I more or less unable to control > the mouse when that happens. Hmm. Just seen this. I'll see if I can work around

Re: [PATCH] Make appletouch shut up when it has nothing to say

2007-05-15 Thread Soeren Sonnenburg
On Sun, 2007-05-13 at 18:58 -0700, Pete Zaitcev wrote: > On Sun, 13 May 2007 20:57:25 +0100, Matthew Garrett <[EMAIL PROTECTED]> wrote: > > > Ok, I've tidied this up a little. [...] > > Looks fine here... well, almost. Did you try rmmod (I don't even know if > it's applicable, sorry)? Usually, wh

Re: [PATCH] Make appletouch shut up when it has nothing to say

2007-05-13 Thread Pete Zaitcev
On Sun, 13 May 2007 20:57:25 +0100, Matthew Garrett <[EMAIL PROTECTED]> wrote: > Ok, I've tidied this up a little. [...] Looks fine here... well, almost. Did you try rmmod (I don't even know if it's applicable, sorry)? Usually, when schedule_work is involved, you want to make sure that a schedule

Re: [PATCH] Make appletouch shut up when it has nothing to say

2007-05-13 Thread Soeren Sonnenburg
On Sun, 2007-05-13 at 20:57 +0100, Matthew Garrett wrote: > Ok, I've tidied this up a little. I've separated the actual mode init > code into a separate function in order to avoid code duplication, and no > longer creating a new workqueue. The only other change is something that > I /think/ is a

Re: [PATCH] Make appletouch shut up when it has nothing to say

2007-05-13 Thread Matthew Garrett
Ok, I've tidied this up a little. I've separated the actual mode init code into a separate function in order to avoid code duplication, and no longer creating a new workqueue. The only other change is something that I /think/ is actually a bug in the driver to begin with, but I'd like some more

Re: [PATCH] Make appletouch shut up when it has nothing to say

2007-05-13 Thread Pete Zaitcev
On Sun, 13 May 2007 18:20:53 +0100, Matthew Garrett <[EMAIL PROTECTED]> wrote: > +static void atp_reinit(struct work_struct *work) > +{ > + char data[8]; > + size = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > +ATP_GEYSER3_MODE_READ_REQUEST_ID, > +

[PATCH] Make appletouch shut up when it has nothing to say

2007-05-13 Thread Matthew Garrett
The appletouch devices found in the Intel Macs (and possibly some later PPC ones?) send a constant stream of packets after the first touch. This results in the kernel waking up around once every couple of milliseconds to process them, making it almost impossible to spend any significant period