>Shouldn't be applied without further analysis.
I don't think further analysis is required before this change be done, the
missing
conversion is rather obvious when comparing to all other functions in that file.
Whether the observed crashes really origin from the missing bits here is a
I wrote:
> Unfortunately an author of lib/swiotlb.c chose to call many variables
> holding *virtual* addresses "dma_addr". Note how that file at the same
> time contains variables like "dma_addr_t dma_handle".
And there is even one occurrence of a "dma_addr" holding a physical
address/ bus
On 2/6/2007 8:56 AM, Andi Kleen wrote:
>> > From: David Moore <[EMAIL PROTECTED]>
...
>> > It fixes real crashes:
>> > http://lists.opensuse.org/opensuse-bugs/2006-12/msg02943.html
>> > http://qa.mandriva.com/show_bug.cgi?id=28224
>> >
On 2/6/2007 8:56 AM, Andi Kleen wrote:
From: David Moore [EMAIL PROTECTED]
...
It fixes real crashes:
http://lists.opensuse.org/opensuse-bugs/2006-12/msg02943.html
http://qa.mandriva.com/show_bug.cgi?id=28224
I wrote:
Unfortunately an author of lib/swiotlb.c chose to call many variables
holding *virtual* addresses dma_addr. Note how that file at the same
time contains variables like dma_addr_t dma_handle.
And there is even one occurrence of a dma_addr holding a physical
address/ bus address, unlike
Shouldn't be applied without further analysis.
I don't think further analysis is required before this change be done, the
missing
conversion is rather obvious when comparing to all other functions in that file.
Whether the observed crashes really origin from the missing bits here is a
different
On Monday 05 February 2007 22:35, Andrew Morton wrote:
> On Sun, 04 Feb 2007 13:39:40 -0500
> David Moore <[EMAIL PROTECTED]> wrote:
>
> > From: David Moore <[EMAIL PROTECTED]>
> >
> > Adds missing call to phys_to_virt() in the
> > lib/swiotlb.c:swiotlb_sync_sg() function. Without this change,
On Sun, 04 Feb 2007 13:39:40 -0500
David Moore <[EMAIL PROTECTED]> wrote:
> From: David Moore <[EMAIL PROTECTED]>
>
> Adds missing call to phys_to_virt() in the
> lib/swiotlb.c:swiotlb_sync_sg() function. Without this change, a kernel
> panic will always occur whenever a SWIOTLB bounce buffer
On Sun, 04 Feb 2007 13:39:40 -0500
David Moore [EMAIL PROTECTED] wrote:
From: David Moore [EMAIL PROTECTED]
Adds missing call to phys_to_virt() in the
lib/swiotlb.c:swiotlb_sync_sg() function. Without this change, a kernel
panic will always occur whenever a SWIOTLB bounce buffer from a
On Monday 05 February 2007 22:35, Andrew Morton wrote:
On Sun, 04 Feb 2007 13:39:40 -0500
David Moore [EMAIL PROTECTED] wrote:
From: David Moore [EMAIL PROTECTED]
Adds missing call to phys_to_virt() in the
lib/swiotlb.c:swiotlb_sync_sg() function. Without this change, a kernel
David Moore wrote:
[...]
> considering the severity of this one-liner bug, I would like to
> request that this simplified patch make it into 2.6.20, despite how
> close we are to the final cut.
So we were too close. Maybe the -stable team likes to have it in 2.6.20.1.
> It fixes real crashes:
>
From: David Moore <[EMAIL PROTECTED]>
Adds missing call to phys_to_virt() in the
lib/swiotlb.c:swiotlb_sync_sg() function. Without this change, a kernel
panic will always occur whenever a SWIOTLB bounce buffer from a
scatter-gather list gets synced.
Signed-off-by: David Moore <[EMAIL
From: David Moore [EMAIL PROTECTED]
Adds missing call to phys_to_virt() in the
lib/swiotlb.c:swiotlb_sync_sg() function. Without this change, a kernel
panic will always occur whenever a SWIOTLB bounce buffer from a
scatter-gather list gets synced.
Signed-off-by: David Moore [EMAIL PROTECTED]
David Moore wrote:
[...]
considering the severity of this one-liner bug, I would like to
request that this simplified patch make it into 2.6.20, despite how
close we are to the final cut.
So we were too close. Maybe the -stable team likes to have it in 2.6.20.1.
It fixes real crashes:
14 matches
Mail list logo