Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-25 Thread Oliver Neukum
Am Donnerstag, 24. Januar 2008 21:28:33 schrieb Greg KH: > And if you see problems in the usbfs implementation with regards to > lifetime rules (becides the devices file), please let me know. All looks sane. Regards Oliver -- To unsubscribe from this list: send the line "

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Greg KH
On Thu, Jan 24, 2008 at 09:00:21PM +0100, Oliver Neukum wrote: > Am Donnerstag, 24. Januar 2008 19:03:13 schrieb Greg KH: > > And the unplug issue at a filesystem level should be pretty trivial to > > handle, we do it all the time in /proc and /sys and other virtual > > filesystems (usbfs) with no

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Pekka Enberg
Hi, On Jan 24, 2008 10:00 PM, Oliver Neukum <[EMAIL PROTECTED]> wrote: > A discussion about lifetime rules for objects in sysfs anyone? ;-> Furthermore, you need to unmount all devices before you can unplug one of them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Pekka Enberg
Hi Oliver, On Jan 24, 2008 9:57 PM, Oliver Neukum <[EMAIL PROTECTED]> wrote: > Are you proposing to mount a _character_ device? /me looks Yeah, I am proposing to mount whatever usb_register_dev() pops up in /dev (which indeed is a character device). Is that a problem? Pek

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Oliver Neukum
Am Donnerstag, 24. Januar 2008 20:25:35 schrieb Pekka J Enberg: > Well, that's how it works for all other music players (especially ones > that support USB storage natively). But anyway, here's a skeleton driver > for what I was proposing in case someone is interested. > Are you proposing to mo

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Oliver Neukum
Am Donnerstag, 24. Januar 2008 19:03:13 schrieb Greg KH: > And the unplug issue at a filesystem level should be pretty trivial to > handle, we do it all the time in /proc and /sys and other virtual > filesystems (usbfs) with no problems. A discussion about lifetime rules for objects in sysfs anyon

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Pekka J Enberg
Hi Greg, On Thu, Jan 24, 2008 at 07:42:20PM +0200, Pekka Enberg wrote: > > Yeah, that would work but why do we want to mount all devices under > > the same mount point? If you move device discovery to ->probe() it's > > simple to have per-device mount points by overriding ->get_sb() to > > check f

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Greg KH
On Thu, Jan 24, 2008 at 07:42:20PM +0200, Pekka Enberg wrote: > Hi Greg, > > On Jan 24, 2008 7:20 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > > So it's not a simple code change at all. > > > > Just create a root directory for every device that is seen in the > > probe() function. That should be pr

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Pekka Enberg
Hi Greg, On Jan 24, 2008 7:20 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > So it's not a simple code change at all. > > Just create a root directory for every device that is seen in the > probe() function. That should be pretty simple to do. Yeah, that would work but why do we want to mount all de

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Greg KH
On Thu, Jan 24, 2008 at 07:06:39PM +0200, Pekka Enberg wrote: > Hi Greg, > > On Jan 24, 2008 6:44 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > No, that's not the problem. The code should just be using > > usb_register_driver() and then doing what it needs to do in the probe() > > callback, like any

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Pekka Enberg
Hi Greg, On Jan 24, 2008 6:44 PM, Greg KH <[EMAIL PROTECTED]> wrote: > No, that's not the problem. The code should just be using > usb_register_driver() and then doing what it needs to do in the probe() > callback, like any other USB driver. > > By calling usb_find_device() it allows more than on

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Greg KH
On Thu, Jan 24, 2008 at 01:19:25PM +0200, Pekka Enberg wrote: > Hi Wilco, > > On Jan 24, 2008 12:05 PM, Wilco Beekhuizen <[EMAIL PROTECTED]> wrote: > > Most code is pretty ancient, I just manage it so it compiles with > > recent kernels. Is there somehting exported that is similar to > > usb_find_

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Pekka Enberg
Hi, On Jan 24, 2008 2:58 PM, Oliver Neukum <[EMAIL PROTECTED]> wrote: > So we put it into drivers/usb/misc > Does that change the code? Yes. It's assumes only one device is plugged in. On Jan 24, 2008 2:58 PM, Oliver Neukum <[EMAIL PROTECTED]> wrote: > How do you make a block device on top of th

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Oliver Neukum
Am Donnerstag, 24. Januar 2008 13:34:00 schrieb Pekka Enberg: > Hi Oliver, > > On Jan 24, 2008 2:24 PM, Oliver Neukum <[EMAIL PROTECTED]> wrote: > > > Sure but the filesystems in fs/ are general purpose and they can be > > > mounted on top of any block device (except for the in-memory ones like >

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Pekka Enberg
Hi Oliver, On Jan 24, 2008 2:24 PM, Oliver Neukum <[EMAIL PROTECTED]> wrote: > > Sure but the filesystems in fs/ are general purpose and they can be > > mounted on top of any block device (except for the in-memory ones like > > nfs, cifs, jffs, ... But none of them mess around with *hardware*. Su

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Oliver Neukum
Am Donnerstag, 24. Januar 2008 12:52:45 schrieb Pekka Enberg: > Hi Oliver, > > On Jan 24, 2008 1:49 PM, Oliver Neukum <[EMAIL PROTECTED]> wrote: > > A quick glance through the files at sourceforge indicates that this > > device use a file transfer protocol. Mapping this to a simple device > > is h

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Pekka Enberg
Hi Oliver, On Jan 24, 2008 1:49 PM, Oliver Neukum <[EMAIL PROTECTED]> wrote: > A quick glance through the files at sourceforge indicates that this > device use a file transfer protocol. Mapping this to a simple device > is hard. A fs is quite natural a representation of that. Sure but the filesys

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Oliver Neukum
Am Donnerstag, 24. Januar 2008 12:19:25 schrieb Pekka Enberg: > AFAICT the whole thing should be a proper USB driver in drivers/usb/ > and not a "filesystem" in fs/ A quick glance through the files at sourceforge indicates that this device use a file transfer protocol. Mapping this to a simple dev

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Pekka Enberg
Hi Wilco, On Jan 24, 2008 12:05 PM, Wilco Beekhuizen <[EMAIL PROTECTED]> wrote: > Most code is pretty ancient, I just manage it so it compiles with > recent kernels. Is there somehting exported that is similar to > usb_find_device? The problem is that iriverfs shouldn't be calling usb_find_device

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-24 Thread Wilco Beekhuizen
2008/1/24, Greg KH <[EMAIL PROTECTED]>: > On Tue, Jan 22, 2008 at 08:18:32PM +0100, Wilco Beekhuizen wrote: > > 2.6.24-rc8 (possibly lower rc's too) has usb_find_device removed from > > usb.c. This causes problems when compiling modules that need > > usb_find_device. > > This patch puts the symbol

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-23 Thread Greg KH
On Tue, Jan 22, 2008 at 08:18:32PM +0100, Wilco Beekhuizen wrote: > 2.6.24-rc8 (possibly lower rc's too) has usb_find_device removed from > usb.c. This causes problems when compiling modules that need > usb_find_device. > This patch puts the symbol back in place. Unless someone has a good > reason

Re: [PATCH] Missing usb_find_device symbol from usb.c

2008-01-22 Thread Adrian Bunk
On Tue, Jan 22, 2008 at 08:18:32PM +0100, Wilco Beekhuizen wrote: > 2.6.24-rc8 (possibly lower rc's too) has usb_find_device removed from > usb.c. This causes problems when compiling modules that need > usb_find_device. > This patch puts the symbol back in place. Unless someone has a good > reason

[PATCH] Missing usb_find_device symbol from usb.c

2008-01-22 Thread Wilco Beekhuizen
2.6.24-rc8 (possibly lower rc's too) has usb_find_device removed from usb.c. This causes problems when compiling modules that need usb_find_device. This patch puts the symbol back in place. Unless someone has a good reason not to include usb_find_device? --- linux-2.6.24-rc8/drivers/usb/core/usb.c