Re: [NFS] [PATCH] NFS: fix client hang due to race condition

2005-07-07 Thread Nick Wilson
On Wed, Jul 06, 2005 at 07:11:25PM -0700, Lever, Charles wrote: > > The flags field in struct nfs_inode is protected by the BKL. The > > following two code paths (there may be more, but my test program only > > hits these two) modify the flags without obtaining the lock: > > > > nfs_end_data_

RE: [NFS] [PATCH] NFS: fix client hang due to race condition

2005-07-06 Thread Lever, Charles
> The flags field in struct nfs_inode is protected by the BKL. The > following two code paths (there may be more, but my test program only > hits these two) modify the flags without obtaining the lock: > > nfs_end_data_update > nfs_release > nfs_file_release > __fput > fput >

Re: [PATCH] NFS: fix client hang due to race condition

2005-07-06 Thread Andrew Morton
Nick Wilson <[EMAIL PROTECTED]> wrote: > > The flags field in struct nfs_inode is protected by the BKL. This patch > fixes a couple places where the lock is not obtained before changing the > flags. > Yeah, nasty. Well caught. > } > invalidate_inode_pages2(mapping);

[PATCH] NFS: fix client hang due to race condition

2005-07-06 Thread Nick Wilson
The flags field in struct nfs_inode is protected by the BKL. The following two code paths (there may be more, but my test program only hits these two) modify the flags without obtaining the lock: nfs_end_data_update nfs_release nfs_file_release __fput fput filp_close s