Re: [PATCH] NFSD, lost nfserrno() call in nfsd_setattr()

2014-03-25 Thread J. Bruce Fields
On Tue, Mar 25, 2014 at 05:19:02PM +0900, J. R. Okajima wrote: > > "J. Bruce Fields": > > On Wed, Feb 19, 2014 at 12:27:53AM +0900, J. R. Okajima wrote: > > > > > > There is a regression in > > > 208d0ac 2014-01-07 nfsd4: break only delegations when appropriate > > > which deletes an nfserrno()

Re: [PATCH] NFSD, lost nfserrno() call in nfsd_setattr()

2014-03-25 Thread J. R. Okajima
"J. Bruce Fields": > On Wed, Feb 19, 2014 at 12:27:53AM +0900, J. R. Okajima wrote: > > > > There is a regression in > > 208d0ac 2014-01-07 nfsd4: break only delegations when appropriate > > which deletes an nfserrno() call in nfsd_setattr() (by accident, > > probably), and NFSD becomes ignor

Re: [PATCH] NFSD, lost nfserrno() call in nfsd_setattr()

2014-02-18 Thread J. Bruce Fields
On Wed, Feb 19, 2014 at 12:27:53AM +0900, J. R. Okajima wrote: > > There is a regression in > 208d0ac 2014-01-07 nfsd4: break only delegations when appropriate > which deletes an nfserrno() call in nfsd_setattr() (by accident, > probably), and NFSD becomes ignoring an error from VFS. > > He

[PATCH] NFSD, lost nfserrno() call in nfsd_setattr()

2014-02-18 Thread J. R. Okajima
There is a regression in 208d0ac 2014-01-07 nfsd4: break only delegations when appropriate which deletes an nfserrno() call in nfsd_setattr() (by accident, probably), and NFSD becomes ignoring an error from VFS. Here is a patch to fix it. J. R. Okajima diff --git a/fs/nfsd/vfs.c b/fs/n