Re: [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown

2007-12-13 Thread Trond Myklebust
On Thu, 2007-12-13 at 09:40 -0500, Jeff Layton wrote: > On Sat, 8 Dec 2007 14:07:47 + > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > + mutex_lock(_mutex); > > > + while (atomic_read(_ref) != 0) { > > > > might be better to do the refcounting outside the thread and use the > >

Re: [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown

2007-12-13 Thread Jeff Layton
On Sat, 8 Dec 2007 14:07:47 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > + mutex_lock(_mutex); > > + while (atomic_read(_ref) != 0) { > > might be better to do the refcounting outside the thread and use the > kthread api, which is something we still need to do for lockd anyway. >

Re: [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown

2007-12-13 Thread Jeff Layton
On Sat, 8 Dec 2007 14:07:47 + Christoph Hellwig [EMAIL PROTECTED] wrote: + mutex_lock(nlmsvc_mutex); + while (atomic_read(nlmsvc_ref) != 0) { might be better to do the refcounting outside the thread and use the kthread api, which is something we still need to do for lockd anyway.

Re: [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown

2007-12-13 Thread Trond Myklebust
On Thu, 2007-12-13 at 09:40 -0500, Jeff Layton wrote: On Sat, 8 Dec 2007 14:07:47 + Christoph Hellwig [EMAIL PROTECTED] wrote: + mutex_lock(nlmsvc_mutex); + while (atomic_read(nlmsvc_ref) != 0) { might be better to do the refcounting outside the thread and use the kthread

Re: [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown

2007-12-08 Thread Jeff Layton
On Sat, 8 Dec 2007 14:07:47 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > + mutex_lock(_mutex); > > + while (atomic_read(_ref) != 0) { > > might be better to do the refcounting outside the thread and use the > kthread api, which is something we still need to do for lockd anyway. >

Re: [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown

2007-12-08 Thread Christoph Hellwig
> + mutex_lock(_mutex); > + while (atomic_read(_ref) != 0) { might be better to do the refcounting outside the thread and use the kthread api, which is something we still need to do for lockd anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

[PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown

2007-12-08 Thread Jeff Layton
When a lock that a client is blocking on comes free, lockd does this in nlmsvc_grant_blocked(): nlm_async_call(block->b_call, NLMPROC_GRANTED_MSG, _grant_ops); the callback from this call is nlmsvc_grant_callback(). That function does this at the end to wake up lockd:

Re: [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown

2007-12-08 Thread Christoph Hellwig
+ mutex_lock(nlmsvc_mutex); + while (atomic_read(nlmsvc_ref) != 0) { might be better to do the refcounting outside the thread and use the kthread api, which is something we still need to do for lockd anyway. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

[PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown

2007-12-08 Thread Jeff Layton
When a lock that a client is blocking on comes free, lockd does this in nlmsvc_grant_blocked(): nlm_async_call(block-b_call, NLMPROC_GRANTED_MSG, nlmsvc_grant_ops); the callback from this call is nlmsvc_grant_callback(). That function does this at the end to wake up lockd:

Re: [PATCH] NLM: Add lockd reference counting and clean up lockd startup and shutdown

2007-12-08 Thread Jeff Layton
On Sat, 8 Dec 2007 14:07:47 + Christoph Hellwig [EMAIL PROTECTED] wrote: + mutex_lock(nlmsvc_mutex); + while (atomic_read(nlmsvc_ref) != 0) { might be better to do the refcounting outside the thread and use the kthread api, which is something we still need to do for lockd anyway.