Re: [PATCH] NTP: remove clock_was_set() call to prevent deadlock

2007-07-04 Thread Thomas Gleixner
On Wed, 2007-07-04 at 13:06 +0200, Roman Zippel wrote: > Hi, > > On Tuesday 03 July 2007, Thomas Gleixner wrote: > > > The clock_was_set() call in seconds_overflow() which happens only when > > leap seconds are inserted / deleted is wrong in two aspects: > > > > 1. it results in a call to on_each

Re: [PATCH] NTP: remove clock_was_set() call to prevent deadlock

2007-07-04 Thread Roman Zippel
Hi, On Tuesday 03 July 2007, Thomas Gleixner wrote: > The clock_was_set() call in seconds_overflow() which happens only when > leap seconds are inserted / deleted is wrong in two aspects: > > 1. it results in a call to on_each_cpu() with interrupts disabled > 2. it is potential deadlock source vs

Re: [PATCH] NTP: remove clock_was_set() call to prevent deadlock

2007-07-03 Thread Thomas Gleixner
On Tue, 2007-07-03 at 20:05 +0200, Thomas Gleixner wrote: > The clock_was_set() call in seconds_overflow() which happens only when > leap seconds are inserted / deleted is wrong in two aspects: > > 1. it results in a call to on_each_cpu() with interrupts disabled > 2. it is potential deadlock sour

Re: [PATCH] NTP: remove clock_was_set() call to prevent deadlock

2007-07-03 Thread Ingo Molnar
* Thomas Gleixner <[EMAIL PROTECTED]> wrote: > The clock_was_set() call in seconds_overflow() which happens only when > leap seconds are inserted / deleted is wrong in two aspects: > > 1. it results in a call to on_each_cpu() with interrupts disabled > 2. it is potential deadlock source vs. cal

[PATCH] NTP: remove clock_was_set() call to prevent deadlock

2007-07-03 Thread Thomas Gleixner
The clock_was_set() call in seconds_overflow() which happens only when leap seconds are inserted / deleted is wrong in two aspects: 1. it results in a call to on_each_cpu() with interrupts disabled 2. it is potential deadlock source vs. call_lock in smp_call_function() The only possible side effe