Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Jeff Garzik
On 07/27/2012 04:26 PM, Matthew Wilcox wrote: Maybe we should design such a mechanism, but maybe we shouldn't ... as we find common things to do, we tend to move those to sysfs, not ioctls, and the kinds of commands that are being sent here are essentially vendor-specific NVMe commands; it's not

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Matthew Wilcox
On Fri, Jul 27, 2012 at 12:21:00PM -0700, Greg KH wrote: > > > Also, why are you creating your own class? Can't this just be a misc > > > device? And if you want to create your own class, please don't, use a > > > bus, as that is what is really happening here, right? We are trying to > > > move

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Matthew Wilcox
On Fri, Jul 27, 2012 at 03:28:25PM -0400, Jeff Garzik wrote: > On 07/27/2012 02:12 PM, Matthew Wilcox wrote: > >On Fri, Jul 27, 2012 at 10:44:18AM -0600, Keith Busch wrote: > >>Registers a character device for the nvme module and creates character > >>files as /dev/nvmeN for each nvme device probed

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Jeff Garzik
On 07/27/2012 02:12 PM, Matthew Wilcox wrote: On Fri, Jul 27, 2012 at 10:44:18AM -0600, Keith Busch wrote: Registers a character device for the nvme module and creates character files as /dev/nvmeN for each nvme device probed, where N is the device instance. The character devices support nvme ad

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Greg KH
On Fri, Jul 27, 2012 at 03:08:21PM -0400, Matthew Wilcox wrote: > On Fri, Jul 27, 2012 at 11:25:46AM -0700, Greg KH wrote: > > On Fri, Jul 27, 2012 at 02:12:12PM -0400, Matthew Wilcox wrote: > > > I don't see a problem here, but I'm no expert at sysfs / character > > > devices. > > > Alan, Greg, a

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Matthew Wilcox
On Fri, Jul 27, 2012 at 11:25:46AM -0700, Greg KH wrote: > On Fri, Jul 27, 2012 at 02:12:12PM -0400, Matthew Wilcox wrote: > > I don't see a problem here, but I'm no expert at sysfs / character devices. > > Alan, Greg, anyone else see any problems with how this character device is > > created / des

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Greg KH
On Fri, Jul 27, 2012 at 02:12:12PM -0400, Matthew Wilcox wrote: > On Fri, Jul 27, 2012 at 10:44:18AM -0600, Keith Busch wrote: > > Registers a character device for the nvme module and creates character > > files as /dev/nvmeN for each nvme device probed, where N is the device > > instance. The char

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Matthew Wilcox
On Fri, Jul 27, 2012 at 10:44:18AM -0600, Keith Busch wrote: > Registers a character device for the nvme module and creates character > files as /dev/nvmeN for each nvme device probed, where N is the device > instance. The character devices support nvme admin ioctl commands so > that nvme devices w