Re: [PATCH] NVMe: Only release requested regions

On 06/08/2016 01:16 AM, Johannes Thumshirn wrote: On Tue, May 10, 2016 at 03:14:28PM +0200, Johannes Thumshirn wrote: The NVMe driver only requests the PCIe device's memory regions but releases all possible regions (including eventual I/O regions). This leads to a stale warning entry in dmesg

Re: [PATCH] NVMe: Only release requested regions

On 06/08/2016 01:16 AM, Johannes Thumshirn wrote: On Tue, May 10, 2016 at 03:14:28PM +0200, Johannes Thumshirn wrote: The NVMe driver only requests the PCIe device's memory regions but releases all possible regions (including eventual I/O regions). This leads to a stale warning entry in dmesg

Re: [PATCH] NVMe: Only release requested regions

On Tue, May 10, 2016 at 03:14:28PM +0200, Johannes Thumshirn wrote: > The NVMe driver only requests the PCIe device's memory regions but releases > all possible regions (including eventual I/O regions). This leads to a stale > warning entry in dmesg about freeing non existent resources. > >

Re: [PATCH] NVMe: Only release requested regions

On Tue, May 10, 2016 at 03:14:28PM +0200, Johannes Thumshirn wrote: > The NVMe driver only requests the PCIe device's memory regions but releases > all possible regions (including eventual I/O regions). This leads to a stale > warning entry in dmesg about freeing non existent resources. > >

Re: [PATCH] NVMe: Only release requested regions

On Tue, May 24, 2016 at 02:19:17AM -0700, Christoph Hellwig wrote: > On Tue, May 24, 2016 at 11:15:52AM +0200, Johannes Thumshirn wrote: > > As I've probably missed v4.7, is it possible to get it for v4.8? > > Or should I take on the PCI helper functions Christoph suggested first? > > Let's get

Re: [PATCH] NVMe: Only release requested regions

On Tue, May 24, 2016 at 02:19:17AM -0700, Christoph Hellwig wrote: > On Tue, May 24, 2016 at 11:15:52AM +0200, Johannes Thumshirn wrote: > > As I've probably missed v4.7, is it possible to get it for v4.8? > > Or should I take on the PCI helper functions Christoph suggested first? > > Let's get

Re: [PATCH] NVMe: Only release requested regions

On Tue, May 24, 2016 at 11:15:52AM +0200, Johannes Thumshirn wrote: > As I've probably missed v4.7, is it possible to get it for v4.8? > Or should I take on the PCI helper functions Christoph suggested first? Let's get the quick fix in first, and I think it's still 4.7 material.

Re: [PATCH] NVMe: Only release requested regions

On Tue, May 24, 2016 at 11:15:52AM +0200, Johannes Thumshirn wrote: > As I've probably missed v4.7, is it possible to get it for v4.8? > Or should I take on the PCI helper functions Christoph suggested first? Let's get the quick fix in first, and I think it's still 4.7 material.

Re: [PATCH] NVMe: Only release requested regions

On Tue, May 10, 2016 at 03:14:28PM +0200, Johannes Thumshirn wrote: > The NVMe driver only requests the PCIe device's memory regions but releases > all possible regions (including eventual I/O regions). This leads to a stale > warning entry in dmesg about freeing non existent resources. > >

Re: [PATCH] NVMe: Only release requested regions

On Tue, May 10, 2016 at 03:14:28PM +0200, Johannes Thumshirn wrote: > The NVMe driver only requests the PCIe device's memory regions but releases > all possible regions (including eventual I/O regions). This leads to a stale > warning entry in dmesg about freeing non existent resources. > >

Re: [PATCH] NVMe: Only release requested regions

On Thu, May 12, 2016 at 12:03:52AM -0700, Christoph Hellwig wrote: > > static void nvme_dev_unmap(struct nvme_dev *dev) > > { > > + struct pci_dev *pdev = to_pci_dev(dev->dev); > > + int bars; > > + > > if (dev->bar) > > iounmap(dev->bar); > > -

Re: [PATCH] NVMe: Only release requested regions

On Thu, May 12, 2016 at 12:03:52AM -0700, Christoph Hellwig wrote: > > static void nvme_dev_unmap(struct nvme_dev *dev) > > { > > + struct pci_dev *pdev = to_pci_dev(dev->dev); > > + int bars; > > + > > if (dev->bar) > > iounmap(dev->bar); > > -

Re: [PATCH] NVMe: Only release requested regions

> static void nvme_dev_unmap(struct nvme_dev *dev) > { > + struct pci_dev *pdev = to_pci_dev(dev->dev); > + int bars; > + > if (dev->bar) > iounmap(dev->bar); > - pci_release_regions(to_pci_dev(dev->dev)); > + > + bars = pci_select_bars(pdev, IORESOURCE_MEM);

Re: [PATCH] NVMe: Only release requested regions

> static void nvme_dev_unmap(struct nvme_dev *dev) > { > + struct pci_dev *pdev = to_pci_dev(dev->dev); > + int bars; > + > if (dev->bar) > iounmap(dev->bar); > - pci_release_regions(to_pci_dev(dev->dev)); > + > + bars = pci_select_bars(pdev, IORESOURCE_MEM);

Re: [PATCH] NVMe: Only release requested regions

On 05/10/2016 03:14 PM, Johannes Thumshirn wrote: > The NVMe driver only requests the PCIe device's memory regions but releases > all possible regions (including eventual I/O regions). This leads to a stale > warning entry in dmesg about freeing non existent resources. > > Signed-off-by: Johannes

Re: [PATCH] NVMe: Only release requested regions

On 05/10/2016 03:14 PM, Johannes Thumshirn wrote: > The NVMe driver only requests the PCIe device's memory regions but releases > all possible regions (including eventual I/O regions). This leads to a stale > warning entry in dmesg about freeing non existent resources. > > Signed-off-by: Johannes

[PATCH] NVMe: Only release requested regions

The NVMe driver only requests the PCIe device's memory regions but releases all possible regions (including eventual I/O regions). This leads to a stale warning entry in dmesg about freeing non existent resources. Signed-off-by: Johannes Thumshirn --- drivers/nvme/host/pci.c

[PATCH] NVMe: Only release requested regions

The NVMe driver only requests the PCIe device's memory regions but releases all possible regions (including eventual I/O regions). This leads to a stale warning entry in dmesg about freeing non existent resources. Signed-off-by: Johannes Thumshirn --- drivers/nvme/host/pci.c | 9 +++-- 1