Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-04-02 Thread Tony Lindgren
* Ивайло Димитров [130401 13:41]: > It could be that I am misreading something, but RX51 is OMAP3. Yes the FIQs are only accessible in the secure mode starting with omap2. So that also means omap3, 4, 5. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-04-01 Thread Aaro Koskinen
Hi, On Sun, Mar 31, 2013 at 03:05:42PM +0300, Ивайло Димитров wrote: > Yep, the code looks almost identical, I guess with some tweaks all SMC > code from that patch could be removed and instead used the one from SMC > PPA API. > > What I don't get, is why one needs to disable/enable fiqs/irqs: [

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-04-01 Thread Ивайло Димитров
It could be that I am misreading something, but RX51 is OMAP3. Regards, Ivo > Оригинално писмо >От: Tony Lindgren >Относно: Re: [PATCH] OMAP3 ROM Random Number Generator support >До: Ивайло Димитров >Изпратено на: Понеделник, 2013, Април

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-04-01 Thread Tony Lindgren
* Ивайло Димитров [130331 05:10]: > > Hi Pali, > > Yep, the code looks almost identical, I guess with some tweaks all SMC code > from that patch could be removed and instead used the one from SMC PPA API. > > What I don't get, is why one needs to disable/enable fiqs/irqs: > > +static int ca

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-04-01 Thread Tony Lindgren
* Pali Rohár [130331 02:32]: > On Thursday 28 March 2013 22:44:11 Tony Lindgren wrote: > > > > You can use regular clk_get if you add the alias to > > struct omap_clk omap3xxx_clks table. > > Tony, can you show me how? Take a look at the omap3xxx_clks in cclock3xxx_data.c. Note how some entries

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-31 Thread Pali Rohár
On Sunday 31 March 2013 14:05:42 Ивайло Димитров wrote: > Hi Pali, > > Yep, the code looks almost identical, I guess with some tweaks > all SMC code from that patch could be removed and instead > used the one from SMC PPA API. > > What I don't get, is why one needs to disable/enable > fiqs/irqs:

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-31 Thread Ивайло Димитров
we can get some understanding... Regards, Ivo > Оригинално писмо >От: Pali Rohár >Относно: Re: [PATCH] OMAP3 ROM Random Number Generator support >До: Tony Lindgren >Изпратено на: Неделя, 2013, Март 31 12:28:12 EEST > > >On Thursday 28 March 2013 2

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-31 Thread Pali Rohár
On Thursday 28 March 2013 22:44:11 Tony Lindgren wrote: > * Pali Rohár [130328 10:58]: > > Here is new version of patch: > > > > --- a/arch/arm/mach-omap2/devices.c > > +++ b/arch/arm/mach-omap2/devices.c > > @@ -486,6 +486,23 @@ static void omap_init_mcspi(void) > > > > static inline void omap

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-28 Thread Tony Lindgren
* Pali Rohár [130328 10:58]: > > Here is new version of patch: > > --- a/arch/arm/mach-omap2/devices.c > +++ b/arch/arm/mach-omap2/devices.c > @@ -486,6 +486,23 @@ static void omap_init_mcspi(void) > static inline void omap_init_mcspi(void) {} > #endif > > +extern u32 *omap3_rom_rng_call(u32

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-28 Thread Pali Rohár
On Wednesday 27 March 2013 23:25:24 Tony Lindgren wrote: > * Pali Rohár [130327 15:08]: > > I will remove above code for checking omap type from hw rand > > driver, because same code is in omap part which creating > > platform_device for this driver. So soc.h is not needed. > > OK thanks, > > To

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-28 Thread Pali Rohár
On Thursday 28 March 2013 10:52:28 Russell King - ARM Linux wrote: > On Wed, Mar 27, 2013 at 02:09:18PM -0700, Tony Lindgren wrote: > > > + setup_timer(&idle_timer, omap3_rom_idle_rng, 0); > > > + rng_clk = clk_get_sys("omap_rng", "ick"); > > Why is this using clk_get_sys when it should be using

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-28 Thread Russell King - ARM Linux
On Wed, Mar 27, 2013 at 02:09:18PM -0700, Tony Lindgren wrote: > > + setup_timer(&idle_timer, omap3_rom_idle_rng, 0); > > + rng_clk = clk_get_sys("omap_rng", "ick"); Why is this using clk_get_sys when it should be using clk_get() with the platform device? -- To unsubscribe from this list: send

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-27 Thread Tony Lindgren
* Pali Rohár [130327 15:08]: > > I will remove above code for checking omap type from hw rand > driver, because same code is in omap part which creating > platform_device for this driver. So soc.h is not needed. OK thanks, Tony -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-27 Thread Pali Rohár
On Wednesday 27 March 2013 22:09:18 Tony Lindgren wrote: > * Pali Rohár [130228 10:09]: > > --- /dev/null > > +++ b/drivers/char/hw_random/omap3-rom-asm.S > > @@ -0,0 +1,27 @@ > > +/* > > + * Copyright (C) 2009 Nokia Corporation > > + * > > + * This program is free software; you can redistribute i

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-27 Thread Tony Lindgren
* Pali Rohár [130228 10:09]: > --- /dev/null > +++ b/drivers/char/hw_random/omap3-rom-asm.S > @@ -0,0 +1,27 @@ > +/* > + * Copyright (C) 2009 Nokia Corporation > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public Licens

Re: [PATCH] OMAP3 ROM Random Number Generator support

2013-03-24 Thread Pali Rohár
On Thursday 28 February 2013 19:05:47 Pali Rohár wrote: > This driver provides kernel-side support for the Random Number > Generator hardware found on OMAP34xx processors. > > This driver is included in Maemo 2.6.28 kernel used on Nokia > N900. > > I fixed driver to work with 3.8 kernel and added

[PATCH] OMAP3 ROM Random Number Generator support

2013-02-28 Thread Pali Rohár
This driver provides kernel-side support for the Random Number Generator hardware found on OMAP34xx processors. This driver is included in Maemo 2.6.28 kernel used on Nokia N900. I fixed driver to work with 3.8 kernel and added platform_driver code to autoload it on omap3 devices. diff --git a/a