Re: [PATCH] OPP: Check for bandwidth values before creating icc paths

2020-06-01 Thread Sibi Sankar
On 2020-06-01 15:45, Viresh Kumar wrote: On 01-06-20, 15:30, Sibi Sankar wrote: Yeah dev_pm_opp_add/dev_pm_opp_set_clkname or pretty much any api doing a dev_pm_opp_get_opp_table without a opp_table node associated with it will run into this issue. Not sure if what you wrote now is correct,

Re: [PATCH] OPP: Check for bandwidth values before creating icc paths

2020-06-01 Thread Viresh Kumar
On 01-06-20, 15:30, Sibi Sankar wrote: > Yeah dev_pm_opp_add/dev_pm_opp_set_clkname > or pretty much any api doing a > dev_pm_opp_get_opp_table without > a opp_table node associated with > it will run into this issue. Not sure if what you wrote now is correct, the problem shouldn't happen from

Re: [PATCH] OPP: Check for bandwidth values before creating icc paths

2020-06-01 Thread Sibi Sankar
On 2020-06-01 12:43, Viresh Kumar wrote: On 01-06-20, 12:09, Sibi Sankar wrote: On 2020-06-01 09:37, Viresh Kumar wrote: > On 29-05-20, 19:47, Sibi Sankar wrote: > > opp_np needs to be subjected > > to NULL check as well. > > No, it isn't. It should already be valid and is set by the OPP core.

Re: [PATCH] OPP: Check for bandwidth values before creating icc paths

2020-06-01 Thread Viresh Kumar
On 01-06-20, 12:09, Sibi Sankar wrote: > On 2020-06-01 09:37, Viresh Kumar wrote: > > On 29-05-20, 19:47, Sibi Sankar wrote: > > > opp_np needs to be subjected > > > to NULL check as well. > > > > No, it isn't. It should already be valid and is set by the OPP core. > > Actually we don't need to

Re: [PATCH] OPP: Check for bandwidth values before creating icc paths

2020-06-01 Thread Sibi Sankar
On 2020-06-01 09:37, Viresh Kumar wrote: On 29-05-20, 19:47, Sibi Sankar wrote: opp_np needs to be subjected to NULL check as well. No, it isn't. It should already be valid and is set by the OPP core. Actually we don't need to do of_node_get(opp_table->np) and just use np, I did that to not

Re: [PATCH] OPP: Check for bandwidth values before creating icc paths

2020-05-31 Thread Viresh Kumar
On 29-05-20, 19:47, Sibi Sankar wrote: > opp_np needs to be subjected > to NULL check as well. No, it isn't. It should already be valid and is set by the OPP core. Actually we don't need to do of_node_get(opp_table->np) and just use np, I did that to not have a special case while putting the

Re: [PATCH] OPP: Check for bandwidth values before creating icc paths

2020-05-29 Thread Sibi Sankar
On 2020-05-29 10:50, Viresh Kumar wrote: On 28-05-20, 00:54, Sibi Sankar wrote: Prevent the core from creating and voting on icc paths when the opp-table does not have the bandwidth values populated. Currently this check is performed on the first OPP node. Signed-off-by: Sibi Sankar ---

Re: [PATCH] OPP: Check for bandwidth values before creating icc paths

2020-05-28 Thread Viresh Kumar
On 28-05-20, 00:54, Sibi Sankar wrote: > Prevent the core from creating and voting on icc paths when the > opp-table does not have the bandwidth values populated. Currently > this check is performed on the first OPP node. > > Signed-off-by: Sibi Sankar > --- > drivers/opp/of.c | 15

[PATCH] OPP: Check for bandwidth values before creating icc paths

2020-05-27 Thread Sibi Sankar
Prevent the core from creating and voting on icc paths when the opp-table does not have the bandwidth values populated. Currently this check is performed on the first OPP node. Signed-off-by: Sibi Sankar --- drivers/opp/of.c | 15 +++ 1 file changed, 15 insertions(+) diff --git