Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-22 Thread Josh Poimboeuf
On Thu, Dec 21, 2017 at 11:10:46PM +1100, Michael Ellerman wrote: > Josh Poimboeuf writes: > > > On Tue, Dec 19, 2017 at 12:28:33PM +0100, Torsten Duwe wrote: > >> On Mon, Dec 18, 2017 at 12:56:22PM -0600, Josh Poimboeuf wrote: > >> > On Mon, Dec 18, 2017 at 03:33:34PM

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-22 Thread Josh Poimboeuf
On Thu, Dec 21, 2017 at 11:10:46PM +1100, Michael Ellerman wrote: > Josh Poimboeuf writes: > > > On Tue, Dec 19, 2017 at 12:28:33PM +0100, Torsten Duwe wrote: > >> On Mon, Dec 18, 2017 at 12:56:22PM -0600, Josh Poimboeuf wrote: > >> > On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-21 Thread Michael Ellerman
Josh Poimboeuf writes: > On Tue, Dec 19, 2017 at 12:28:33PM +0100, Torsten Duwe wrote: >> On Mon, Dec 18, 2017 at 12:56:22PM -0600, Josh Poimboeuf wrote: >> > On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin wrote: >> > > On Sun, 17 Dec 2017 20:58:54 -0600 >> > >

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-21 Thread Michael Ellerman
Josh Poimboeuf writes: > On Tue, Dec 19, 2017 at 12:28:33PM +0100, Torsten Duwe wrote: >> On Mon, Dec 18, 2017 at 12:56:22PM -0600, Josh Poimboeuf wrote: >> > On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin wrote: >> > > On Sun, 17 Dec 2017 20:58:54 -0600 >> > > Josh Poimboeuf wrote:

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-19 Thread Josh Poimboeuf
On Tue, Dec 19, 2017 at 12:28:33PM +0100, Torsten Duwe wrote: > On Mon, Dec 18, 2017 at 12:56:22PM -0600, Josh Poimboeuf wrote: > > On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin wrote: > > > On Sun, 17 Dec 2017 20:58:54 -0600 > > > Josh Poimboeuf wrote: > > > > >

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-19 Thread Josh Poimboeuf
On Tue, Dec 19, 2017 at 12:28:33PM +0100, Torsten Duwe wrote: > On Mon, Dec 18, 2017 at 12:56:22PM -0600, Josh Poimboeuf wrote: > > On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin wrote: > > > On Sun, 17 Dec 2017 20:58:54 -0600 > > > Josh Poimboeuf wrote: > > > > > > > On Fri, Dec 15,

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-19 Thread Torsten Duwe
On Mon, Dec 18, 2017 at 12:56:22PM -0600, Josh Poimboeuf wrote: > On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin wrote: > > On Sun, 17 Dec 2017 20:58:54 -0600 > > Josh Poimboeuf wrote: > > > > > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > >

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-19 Thread Torsten Duwe
On Mon, Dec 18, 2017 at 12:56:22PM -0600, Josh Poimboeuf wrote: > On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin wrote: > > On Sun, 17 Dec 2017 20:58:54 -0600 > > Josh Poimboeuf wrote: > > > > > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > > > > On Tue, 12 Dec

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-18 Thread Nicholas Piggin
On Mon, 18 Dec 2017 12:56:22 -0600 Josh Poimboeuf wrote: > On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin wrote: > > On Sun, 17 Dec 2017 20:58:54 -0600 > > Josh Poimboeuf wrote: > > > > > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-18 Thread Nicholas Piggin
On Mon, 18 Dec 2017 12:56:22 -0600 Josh Poimboeuf wrote: > On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin wrote: > > On Sun, 17 Dec 2017 20:58:54 -0600 > > Josh Poimboeuf wrote: > > > > > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > > > > On Tue, 12 Dec

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-18 Thread Josh Poimboeuf
On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin wrote: > On Sun, 17 Dec 2017 20:58:54 -0600 > Josh Poimboeuf wrote: > > > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > > > On Tue, 12 Dec 2017 08:05:01 -0600 > > > Josh Poimboeuf

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-18 Thread Josh Poimboeuf
On Mon, Dec 18, 2017 at 03:33:34PM +1000, Nicholas Piggin wrote: > On Sun, 17 Dec 2017 20:58:54 -0600 > Josh Poimboeuf wrote: > > > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > > > On Tue, 12 Dec 2017 08:05:01 -0600 > > > Josh Poimboeuf wrote: > > > > > > > On Tue, Dec

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-17 Thread Nicholas Piggin
On Sun, 17 Dec 2017 20:58:54 -0600 Josh Poimboeuf wrote: > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > > On Tue, 12 Dec 2017 08:05:01 -0600 > > Josh Poimboeuf wrote: > > > > > On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-17 Thread Nicholas Piggin
On Sun, 17 Dec 2017 20:58:54 -0600 Josh Poimboeuf wrote: > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > > On Tue, 12 Dec 2017 08:05:01 -0600 > > Josh Poimboeuf wrote: > > > > > On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten Duwe wrote: > > > > Hi all, > > > > > >

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-17 Thread Josh Poimboeuf
On Mon, Dec 18, 2017 at 02:39:06PM +1100, Balbir Singh wrote: > On Mon, Dec 18, 2017 at 1:58 PM, Josh Poimboeuf wrote: > > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > >> On Tue, 12 Dec 2017 08:05:01 -0600 > >> Josh Poimboeuf wrote:

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-17 Thread Josh Poimboeuf
On Mon, Dec 18, 2017 at 02:39:06PM +1100, Balbir Singh wrote: > On Mon, Dec 18, 2017 at 1:58 PM, Josh Poimboeuf wrote: > > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > >> On Tue, 12 Dec 2017 08:05:01 -0600 > >> Josh Poimboeuf wrote: > >> > >> > On Tue, Dec 12, 2017 at

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-17 Thread Balbir Singh
On Mon, Dec 18, 2017 at 1:58 PM, Josh Poimboeuf wrote: > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: >> On Tue, 12 Dec 2017 08:05:01 -0600 >> Josh Poimboeuf wrote: >> >> > On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten Duwe wrote:

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-17 Thread Balbir Singh
On Mon, Dec 18, 2017 at 1:58 PM, Josh Poimboeuf wrote: > On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: >> On Tue, 12 Dec 2017 08:05:01 -0600 >> Josh Poimboeuf wrote: >> >> > On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten Duwe wrote: >> > > Hi all, >> > > >> > > The "Power

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-17 Thread Josh Poimboeuf
On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > On Tue, 12 Dec 2017 08:05:01 -0600 > Josh Poimboeuf wrote: > > > On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten Duwe wrote: > > > Hi all, > > > > > > The "Power Architecture 64-Bit ELF V2 ABI" says in

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-17 Thread Josh Poimboeuf
On Fri, Dec 15, 2017 at 07:40:09PM +1000, Nicholas Piggin wrote: > On Tue, 12 Dec 2017 08:05:01 -0600 > Josh Poimboeuf wrote: > > > On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten Duwe wrote: > > > Hi all, > > > > > > The "Power Architecture 64-Bit ELF V2 ABI" says in section 2.3.2.3: > > >

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-15 Thread Nicholas Piggin
On Tue, 12 Dec 2017 08:05:01 -0600 Josh Poimboeuf wrote: > On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten Duwe wrote: > > Hi all, > > > > The "Power Architecture 64-Bit ELF V2 ABI" says in section 2.3.2.3: > > > > [...] There are several rules that must be adhered to in

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-15 Thread Nicholas Piggin
On Tue, 12 Dec 2017 08:05:01 -0600 Josh Poimboeuf wrote: > On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten Duwe wrote: > > Hi all, > > > > The "Power Architecture 64-Bit ELF V2 ABI" says in section 2.3.2.3: > > > > [...] There are several rules that must be adhered to in order to ensure > >

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-12 Thread Josh Poimboeuf
On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten Duwe wrote: > Hi all, > > The "Power Architecture 64-Bit ELF V2 ABI" says in section 2.3.2.3: > > [...] There are several rules that must be adhered to in order to ensure > reliable and consistent call chain backtracing: > > * Before a function

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-12 Thread Josh Poimboeuf
On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten Duwe wrote: > Hi all, > > The "Power Architecture 64-Bit ELF V2 ABI" says in section 2.3.2.3: > > [...] There are several rules that must be adhered to in order to ensure > reliable and consistent call chain backtracing: > > * Before a function

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-12 Thread Torsten Duwe
On Tue, Dec 12, 2017 at 01:12:37PM +0100, Miroslav Benes wrote: > > I think that this is not enough. You need to also implement > save_stack_trace_tsk_reliable() for powerpc defined as __weak in > kernel/stacktrace.c. See arch/x86/kernel/stacktrace.c for reference, but I > think it would be

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-12 Thread Torsten Duwe
On Tue, Dec 12, 2017 at 01:12:37PM +0100, Miroslav Benes wrote: > > I think that this is not enough. You need to also implement > save_stack_trace_tsk_reliable() for powerpc defined as __weak in > kernel/stacktrace.c. See arch/x86/kernel/stacktrace.c for reference, but I > think it would be

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-12 Thread Miroslav Benes
On Tue, 12 Dec 2017, Torsten Duwe wrote: > Hi all, > > The "Power Architecture 64-Bit ELF V2 ABI" says in section 2.3.2.3: > > [...] There are several rules that must be adhered to in order to ensure > reliable and consistent call chain backtracing: > > * Before a function calls any other

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-12 Thread Miroslav Benes
On Tue, 12 Dec 2017, Torsten Duwe wrote: > Hi all, > > The "Power Architecture 64-Bit ELF V2 ABI" says in section 2.3.2.3: > > [...] There are several rules that must be adhered to in order to ensure > reliable and consistent call chain backtracing: > > * Before a function calls any other

[PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-12 Thread Torsten Duwe
Hi all, The "Power Architecture 64-Bit ELF V2 ABI" says in section 2.3.2.3: [...] There are several rules that must be adhered to in order to ensure reliable and consistent call chain backtracing: * Before a function calls any other function, it shall establish its own stack frame, whose size

[PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

2017-12-12 Thread Torsten Duwe
Hi all, The "Power Architecture 64-Bit ELF V2 ABI" says in section 2.3.2.3: [...] There are several rules that must be adhered to in order to ensure reliable and consistent call chain backtracing: * Before a function calls any other function, it shall establish its own stack frame, whose size