Re: [PATCH] Only reset e820 once, even with multiple memmap=exactmap params

2013-01-10 Thread Yinghai Lu
On Wed, Jan 9, 2013 at 7:21 PM, Thomas Renninger wrote: > I still do not understand why: > > Kexec (kexec/firmware_memmap.c) is setting up the e820 map from: > /sys/firmware/memmap/* > and pass it via bootloader structures. > And this e820 table gets immediately voided by memmap=exactmap > and a n

Re: [PATCH] Only reset e820 once, even with multiple memmap=exactmap params

2013-01-10 Thread Yinghai Lu
On Thu, Jan 10, 2013 at 9:01 AM, Vivek Goyal wrote: > On Thu, Jan 10, 2013 at 08:53:18AM -0800, Yinghai Lu wrote: >> On Thu, Jan 10, 2013 at 6:26 AM, Vivek Goyal wrote: >> > >> > This happens only in case of kdump and not kexec. In case of kdump >> > we want second kernel to use only selected mem

Re: [PATCH] Only reset e820 once, even with multiple memmap=exactmap params

2013-01-10 Thread Vivek Goyal
On Thu, Jan 10, 2013 at 08:53:18AM -0800, Yinghai Lu wrote: > On Thu, Jan 10, 2013 at 6:26 AM, Vivek Goyal wrote: > > > > This happens only in case of kdump and not kexec. In case of kdump > > we want second kernel to use only selected memory areas. > > > > In fact this is one improvement area. In

Re: [PATCH] Only reset e820 once, even with multiple memmap=exactmap params

2013-01-10 Thread Yinghai Lu
On Thu, Jan 10, 2013 at 6:26 AM, Vivek Goyal wrote: > > This happens only in case of kdump and not kexec. In case of kdump > we want second kernel to use only selected memory areas. > > In fact this is one improvement area. Instead of using memmap= entries > in kdump case, we should probably modif

Re: [PATCH] Only reset e820 once, even with multiple memmap=exactmap params

2013-01-10 Thread Vivek Goyal
On Thu, Jan 10, 2013 at 04:21:49AM +0100, Thomas Renninger wrote: > On Tuesday, January 08, 2013 09:19:18 AM Yinghai Lu wrote: > ... > > > > that exactmap logic still have problem: > > We need to check exactmap at first, aka need to scan the whole comand line > > to see if exactmap is there at fir

Re: [PATCH] Only reset e820 once, even with multiple memmap=exactmap params

2013-01-09 Thread Thomas Renninger
On Tuesday, January 08, 2013 09:19:18 AM Yinghai Lu wrote: ... > > that exactmap logic still have problem: > We need to check exactmap at first, aka need to scan the whole comand line > to see if exactmap is there at first and reset e820 tables then handle > other memmap opt. > > Also please upda

Re: [PATCH] Only reset e820 once, even with multiple memmap=exactmap params

2013-01-08 Thread Yinghai Lu
On Tue, Jan 8, 2013 at 8:47 AM, Thomas Renninger wrote: > On Tuesday, January 08, 2013 04:04:56 AM Yinghai Lu wrote: >> On Mon, Jan 7, 2013 at 4:42 PM, Thomas Renninger wrote: >> > memmap=256M$3584M >> >> may need to change to: >> >> memmap=256M\$\$3584M > The problem is (beside the special char

[PATCH] Only reset e820 once, even with multiple memmap=exactmap params

2013-01-08 Thread Thomas Renninger
On Tuesday, January 08, 2013 04:04:56 AM Yinghai Lu wrote: > On Mon, Jan 7, 2013 at 4:42 PM, Thomas Renninger wrote: > > memmap=256M$3584M > > may need to change to: > > memmap=256M\$\$3584M The problem is (beside the special char $) that memmap=exactmap boot param resets all e820 maps every tim