Re: [PATCH] PCI, ACPI: Don't query OSC support with all possible controls

2013-04-03 Thread Bjorn Helgaas
[+cc Bob for spec typo question] On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu wrote: > Found problem on system that firmware that could handle pci aer. > Firmware get error reporting after pci injecting error, before os boots. > But after os boots, firmware can not get report anymore, even pci=no

Re: [PATCH] PCI, ACPI: Don't query OSC support with all possible controls

2013-03-29 Thread Yinghai Lu
On Fri, Mar 29, 2013 at 6:12 PM, Rafael J. Wysocki wrote: > On Friday, March 29, 2013 06:02:45 PM Yinghai Lu wrote: >> On Fri, Mar 29, 2013 at 5:36 PM, Rafael J. Wysocki wrote: >> >> - /* Run _OSC query for all possible controls. */ >> >> - capbuf[OSC_CONTROL_TYPE] = OSC_P

Re: [PATCH] PCI, ACPI: Don't query OSC support with all possible controls

2013-03-29 Thread Rafael J. Wysocki
On Friday, March 29, 2013 06:02:45 PM Yinghai Lu wrote: > On Fri, Mar 29, 2013 at 5:36 PM, Rafael J. Wysocki wrote: > >> - /* Run _OSC query for all possible controls. */ > >> - capbuf[OSC_CONTROL_TYPE] = OSC_PCI_CONTROL_MASKS; > >> + /* Run _OSC query only with

Re: [PATCH] PCI, ACPI: Don't query OSC support with all possible controls

2013-03-29 Thread Yinghai Lu
On Fri, Mar 29, 2013 at 5:36 PM, Rafael J. Wysocki wrote: >> - /* Run _OSC query for all possible controls. */ >> - capbuf[OSC_CONTROL_TYPE] = OSC_PCI_CONTROL_MASKS; >> + /* Run _OSC query only with existing controls. */ >> + capbuf[OSC_CONTROL_TYPE]

Re: [PATCH] PCI, ACPI: Don't query OSC support with all possible controls

2013-03-29 Thread Rafael J. Wysocki
On Wednesday, March 27, 2013 09:28:58 PM Yinghai Lu wrote: > Found problem on system that firmware that could handle pci aer. > Firmware get error reporting after pci injecting error, before os boots. > But after os boots, firmware can not get report anymore, even pci=noaer > is passed. > > Root c

[PATCH] PCI, ACPI: Don't query OSC support with all possible controls

2013-03-27 Thread Yinghai Lu
Found problem on system that firmware that could handle pci aer. Firmware get error reporting after pci injecting error, before os boots. But after os boots, firmware can not get report anymore, even pci=noaer is passed. Root cause: BIOS _OSC has problem with query bit checking. It turns out that