Re: [PATCH] PCI/AER: Fix an AER enabling/disabling race

2018-09-03 Thread Derrick, Jonathan
Hi, After giving this a few days thought, I think the right way is to call pci_enable_pcie_error_reporting after portdrv probe, and prevent AER's pci_walk_bus from enabling err reporting if the port hasn't been probed. I'm going to Self-NAK this and follow-up Sorry for the noise On Sat,

Re: [PATCH] PCI/AER: Fix an AER enabling/disabling race

2018-09-03 Thread Derrick, Jonathan
Hi, After giving this a few days thought, I think the right way is to call pci_enable_pcie_error_reporting after portdrv probe, and prevent AER's pci_walk_bus from enabling err reporting if the port hasn't been probed. I'm going to Self-NAK this and follow-up Sorry for the noise On Sat,

[PATCH] PCI/AER: Fix an AER enabling/disabling race

2018-09-01 Thread Jon Derrick
There is a sequence with non-ACPI root ports where the AER driver can enable error reporting on the tree before port drivers have bound to ports on the tree. The port driver assumes the AER driver will set up error reporting afterwards, so instead add a check if error reporting was set up first.

[PATCH] PCI/AER: Fix an AER enabling/disabling race

2018-09-01 Thread Jon Derrick
There is a sequence with non-ACPI root ports where the AER driver can enable error reporting on the tree before port drivers have bound to ports on the tree. The port driver assumes the AER driver will set up error reporting afterwards, so instead add a check if error reporting was set up first.