Re: [PATCH] PCI/ASPM: Disable ASPM when save/restore PCI state

On Fri, Jan 29, 2021 at 12:44 AM Krzysztof Wilczyński wrote: > > Hi Victor, > > Thank you for working on this! > > [...] > > i = pci_save_pcie_state(dev); > > if (i != 0) > > - return i; > > + goto Exit; > > > > i = pci_save_pcix_state(dev); > > if (

Re: [PATCH] PCI/ASPM: Disable ASPM when save/restore PCI state

Hi Victor, Thank you for working on this! [...] > i = pci_save_pcie_state(dev); > if (i != 0) > - return i; > + goto Exit; > > i = pci_save_pcix_state(dev); > if (i != 0) > - return i; > + goto Exit; [...] > +Exit: > +

[PATCH] PCI/ASPM: Disable ASPM when save/restore PCI state

Certain PCIe devices (e.g. GL9750) have high penalties (e.g. high Port T_POWER_ON) when exiting L1 but enter L1 aggressively. As a result, such devices enter and exit L1 frequently during pci_save_state and pci_restore_state; eventually causing poor suspend/resume performance. Based on the observa