Re: [PATCH] PCI: Disallow ASPM on ASMedia ASM1083/1085 PCIe-PCI bridge

2020-07-29 Thread Bjorn Helgaas
On Tue, Jul 21, 2020 at 08:18:03PM -0600, Robert Hancock wrote: > Recently ASPM handling was changed to no longer disable ASPM on all > PCIe to PCI bridges. Unfortunately these ASMedia PCIe to PCI bridge > devices don't seem to function properly with ASPM enabled, as they > cause the parent PCIe

Re: [PATCH] PCI: Disallow ASPM on ASMedia ASM1083/1085 PCIe-PCI bridge

2020-07-22 Thread Robert Hancock
On Wed, Jul 22, 2020 at 7:04 PM Bjorn Helgaas wrote: > > On Wed, Jul 22, 2020 at 06:46:06PM -0600, Robert Hancock wrote: > > On Wed, Jul 22, 2020 at 11:40 AM Bjorn Helgaas wrote: > > > On Tue, Jul 21, 2020 at 08:18:03PM -0600, Robert Hancock wrote: > > > > Recently ASPM handling was changed to

Re: [PATCH] PCI: Disallow ASPM on ASMedia ASM1083/1085 PCIe-PCI bridge

2020-07-22 Thread Bjorn Helgaas
On Wed, Jul 22, 2020 at 06:46:06PM -0600, Robert Hancock wrote: > On Wed, Jul 22, 2020 at 11:40 AM Bjorn Helgaas wrote: > > On Tue, Jul 21, 2020 at 08:18:03PM -0600, Robert Hancock wrote: > > > Recently ASPM handling was changed to no longer disable ASPM on all > > > PCIe to PCI bridges.

Re: [PATCH] PCI: Disallow ASPM on ASMedia ASM1083/1085 PCIe-PCI bridge

2020-07-22 Thread Robert Hancock
On Wed, Jul 22, 2020 at 11:40 AM Bjorn Helgaas wrote: > > [+cc Puranjay] > > On Tue, Jul 21, 2020 at 08:18:03PM -0600, Robert Hancock wrote: > > Recently ASPM handling was changed to no longer disable ASPM on all > > PCIe to PCI bridges. Unfortunately these ASMedia PCIe to PCI bridge > > devices

Re: [PATCH] PCI: Disallow ASPM on ASMedia ASM1083/1085 PCIe-PCI bridge

2020-07-22 Thread Bjorn Helgaas
[+cc Puranjay] On Tue, Jul 21, 2020 at 08:18:03PM -0600, Robert Hancock wrote: > Recently ASPM handling was changed to no longer disable ASPM on all > PCIe to PCI bridges. Unfortunately these ASMedia PCIe to PCI bridge > devices don't seem to function properly with ASPM enabled, as they > cause

[PATCH] PCI: Disallow ASPM on ASMedia ASM1083/1085 PCIe-PCI bridge

2020-07-21 Thread Robert Hancock
Recently ASPM handling was changed to no longer disable ASPM on all PCIe to PCI bridges. Unfortunately these ASMedia PCIe to PCI bridge devices don't seem to function properly with ASPM enabled, as they cause the parent PCIe root port to cause repeated AER timeout errors. In addition to flooding