Re: [PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-30 Thread Honghui Zhang
On Thu, 2019-01-31 at 11:03 +0800, Honghui Zhang wrote: > On Wed, 2019-01-30 at 09:49 -0600, Bjorn Helgaas wrote: > > On Wed, Jan 02, 2019 at 02:03:53PM +0800, honghui.zh...@mediatek.com wrote: > > > From: Honghui Zhang > > > > > > drivers/pci/pcie-mediatek.c:720:13-16: WARNING: Suspicious code.

Re: [PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-30 Thread Honghui Zhang
On Wed, 2019-01-30 at 09:49 -0600, Bjorn Helgaas wrote: > On Wed, Jan 02, 2019 at 02:03:53PM +0800, honghui.zh...@mediatek.com wrote: > > From: Honghui Zhang > > > > drivers/pci/pcie-mediatek.c:720:13-16: WARNING: Suspicious code. > > resource_size is maybe missing with mem > > > > Generated

Re: [PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-30 Thread Honghui Zhang
On Wed, 2019-01-30 at 16:31 +, Lorenzo Pieralisi wrote: > On Wed, Jan 30, 2019 at 09:58:53AM -0600, Bjorn Helgaas wrote: > > On Wed, Jan 30, 2019 at 12:33:47PM +, Lorenzo Pieralisi wrote: > > > On Wed, Jan 02, 2019 at 02:03:53PM +0800, honghui.zh...@mediatek.com > > > wrote: > > > > From:

Re: [PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-30 Thread Lorenzo Pieralisi
On Wed, Jan 30, 2019 at 09:58:53AM -0600, Bjorn Helgaas wrote: > On Wed, Jan 30, 2019 at 12:33:47PM +, Lorenzo Pieralisi wrote: > > On Wed, Jan 02, 2019 at 02:03:53PM +0800, honghui.zh...@mediatek.com wrote: > > > From: Honghui Zhang > > > > > > drivers/pci/pcie-mediatek.c:720:13-16:

Re: [PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-30 Thread Bjorn Helgaas
On Wed, Jan 02, 2019 at 02:03:53PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > drivers/pci/pcie-mediatek.c:720:13-16: WARNING: Suspicious code. > resource_size is maybe missing with mem > > Generated by: scripts/coccinelle/api/resource_size.cocci > > Signed-off-by:

Re: [PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-30 Thread Bjorn Helgaas
On Wed, Jan 30, 2019 at 12:33:47PM +, Lorenzo Pieralisi wrote: > On Wed, Jan 02, 2019 at 02:03:53PM +0800, honghui.zh...@mediatek.com wrote: > > From: Honghui Zhang > > > > drivers/pci/pcie-mediatek.c:720:13-16: WARNING: Suspicious code. > > resource_size is maybe missing with mem > > > >

Re: [PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-30 Thread Bjorn Helgaas
On Wed, Jan 02, 2019 at 02:03:53PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > drivers/pci/pcie-mediatek.c:720:13-16: WARNING: Suspicious code. > resource_size is maybe missing with mem > > Generated by: scripts/coccinelle/api/resource_size.cocci > > Signed-off-by:

Re: [PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-30 Thread Bjorn Helgaas
Please pay attention to the changelog conventions, e.g., next time use "PCI: mediatek: ..." so yours matches "git log --oneline drivers/pci/controller/pcie-mediatek.c" On Wed, Jan 02, 2019 at 02:03:53PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > >

Re: [PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-30 Thread Lorenzo Pieralisi
On Wed, Jan 02, 2019 at 02:03:53PM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > drivers/pci/pcie-mediatek.c:720:13-16: WARNING: Suspicious code. > resource_size is maybe missing with mem > > Generated by: scripts/coccinelle/api/resource_size.cocci > > Signed-off-by:

[PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-01 Thread honghui.zhang
From: Honghui Zhang drivers/pci/pcie-mediatek.c:720:13-16: WARNING: Suspicious code. resource_size is maybe missing with mem Generated by: scripts/coccinelle/api/resource_size.cocci Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 4 +--- 1 file changed, 1