Re: [PATCH] PCI: aardvark: Indicate error in 'val' when config read fails

2020-07-07 Thread Lorenzo Pieralisi
On Tue, Jul 07, 2020 at 04:02:44PM +0200, Pali Rohár wrote: > On Tuesday 07 July 2020 14:53:11 Lorenzo Pieralisi wrote: > > On Fri, Jun 19, 2020 at 12:56:18PM +0200, Pali Rohár wrote: > > > Hello Lorenzo! Could you please review this patch? > > > > > > On Monday 01 June 2020 15:03:15 Pali Rohár wr

Re: [PATCH] PCI: aardvark: Indicate error in 'val' when config read fails

2020-07-07 Thread Pali Rohár
On Tuesday 07 July 2020 14:53:11 Lorenzo Pieralisi wrote: > On Fri, Jun 19, 2020 at 12:56:18PM +0200, Pali Rohár wrote: > > Hello Lorenzo! Could you please review this patch? > > > > On Monday 01 June 2020 15:03:15 Pali Rohár wrote: > > > Most callers of config read do not check for return value.

Re: [PATCH] PCI: aardvark: Indicate error in 'val' when config read fails

2020-07-07 Thread Lorenzo Pieralisi
On Fri, Jun 19, 2020 at 12:56:18PM +0200, Pali Rohár wrote: > Hello Lorenzo! Could you please review this patch? > > On Monday 01 June 2020 15:03:15 Pali Rohár wrote: > > Most callers of config read do not check for return value. But most of the > > ones that do, checks for error indication in 'va

Re: [PATCH] PCI: aardvark: Indicate error in 'val' when config read fails

2020-06-19 Thread Pali Rohár
Hello Lorenzo! Could you please review this patch? On Monday 01 June 2020 15:03:15 Pali Rohár wrote: > Most callers of config read do not check for return value. But most of the > ones that do, checks for error indication in 'val' variable. > > This patch updates error handling in advk_pcie_rd_co

[PATCH] PCI: aardvark: Indicate error in 'val' when config read fails

2020-06-01 Thread Pali Rohár
Most callers of config read do not check for return value. But most of the ones that do, checks for error indication in 'val' variable. This patch updates error handling in advk_pcie_rd_conf() function. If PIO transfer fails then 'val' variable is set to 0x which indicates failture. Signe