Re: [PATCH] PCI: al: add pcie-al.c

2019-03-25 Thread Bjorn Helgaas
On Mon, Mar 25, 2019 at 05:56:35PM +0200, Jonathan Chocron wrote: > On 3/25/19 14:58, Bjorn Helgaas wrote: > > I think you're actually looking for a AMZN0001 device, not a PNP0C02 > > device. Your firmware might have a PNP0C02 _HID and AMZN0001 _CID, but > > that's not relevant here since you're

Re: [PATCH] PCI: al: add pcie-al.c

2019-03-25 Thread Jonathan Chocron
On 3/25/19 14:58, Bjorn Helgaas wrote: Hi Jonathan, Looks good to me. Looks like this hardware is so close to Just Working with the generic driver; it's too bad we have to add more ECAM quirks, but sometimes life gives us lemons. Trivial comments below. Lorenzo may have additional comments

Re: [PATCH] PCI: al: add pcie-al.c

2019-03-25 Thread Bjorn Helgaas
Hi Jonathan, Looks good to me. Looks like this hardware is so close to Just Working with the generic driver; it's too bad we have to add more ECAM quirks, but sometimes life gives us lemons. Trivial comments below. Lorenzo may have additional comments. The subject should be something like:

[PATCH] PCI: al: add pcie-al.c

2019-03-25 Thread jonnyc
From: Jonathan Chocron Adding support for Amazon's Annapurna Labs pcie driver. The HW controller is based on Designware's IP. The HW doesn't support accessing the Root port's config space via ECAM, so we obtain its base address via a PNP0C02 device. Furthermore, the DesignWare PCIe controller do