On Fri, Jun 22, 2007 at 10:12:55AM -0700, Kok, Auke wrote:
>
> Grant Grundler wrote:
> > On Sat, Jun 09, 2007 at 01:12:21PM -0700, Auke Kok wrote:
> >> Since the PCI bus class and revision are in the same dword, we
> >> can fill in both in the same read.
> >>
> >> Other non-x86 arches use
Grant Grundler wrote:
On Sat, Jun 09, 2007 at 01:12:21PM -0700, Auke Kok wrote:
Since the PCI bus class and revision are in the same dword, we
can fill in both in the same read.
Other non-x86 arches use different methods to fill in these values,
make sure to adjust those too.
Yeah, this
Grant Grundler wrote:
On Sat, Jun 09, 2007 at 01:12:21PM -0700, Auke Kok wrote:
Since the PCI bus class and revision are in the same dword, we
can fill in both in the same read.
Other non-x86 arches use different methods to fill in these values,
make sure to adjust those too.
Yeah, this
On Fri, Jun 22, 2007 at 10:12:55AM -0700, Kok, Auke wrote:
Grant Grundler wrote:
On Sat, Jun 09, 2007 at 01:12:21PM -0700, Auke Kok wrote:
Since the PCI bus class and revision are in the same dword, we
can fill in both in the same read.
Other non-x86 arches use different methods to
On Sun, 2007-06-10 at 14:17 +0200, Segher Boessenkool wrote:
> >> + dev->revision = get_int_prop(node, "revision-id", 0);
> >
> > It's not clear to me in the spec if nodes are required to have the
> > "revision-id" property.
>
> It is required for every PCI node.
Yep. I was reading the wrong
On Sun, 2007-06-10 at 14:17 +0200, Segher Boessenkool wrote:
+ dev-revision = get_int_prop(node, revision-id, 0);
It's not clear to me in the spec if nodes are required to have the
revision-id property.
It is required for every PCI node.
Yep. I was reading the wrong spec :)
cheers
+ dev->revision = get_int_prop(node, "revision-id", 0);
It's not clear to me in the spec if nodes are required to have the
"revision-id" property.
It is required for every PCI node.
I guess 0 is a safe default though.
As good as any -- that is, no default is save. 0 should
be "good
On Sat, 2007-06-09 at 13:12 -0700, Auke Kok wrote:
> Since the PCI bus class and revision are in the same dword, we
> can fill in both in the same read.
>
> Other non-x86 arches use different methods to fill in these values,
> make sure to adjust those too.
>
> Signed-off-by: Auke Kok <[EMAIL
On Sat, 2007-06-09 at 13:12 -0700, Auke Kok wrote:
Since the PCI bus class and revision are in the same dword, we
can fill in both in the same read.
Other non-x86 arches use different methods to fill in these values,
make sure to adjust those too.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
+ dev-revision = get_int_prop(node, revision-id, 0);
It's not clear to me in the spec if nodes are required to have the
revision-id property.
It is required for every PCI node.
I guess 0 is a safe default though.
As good as any -- that is, no default is save. 0 should
be good
On Sat, Jun 09, 2007 at 01:12:21PM -0700, Auke Kok wrote:
> Since the PCI bus class and revision are in the same dword, we
> can fill in both in the same read.
>
> Other non-x86 arches use different methods to fill in these values,
> make sure to adjust those too.
Yeah, this looks good to me.
I
Since the PCI bus class and revision are in the same dword, we
can fill in both in the same read.
Other non-x86 arches use different methods to fill in these values,
make sure to adjust those too.
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/pci_64.c |2 ++
Since the PCI bus class and revision are in the same dword, we
can fill in both in the same read.
Other non-x86 arches use different methods to fill in these values,
make sure to adjust those too.
Signed-off-by: Auke Kok [EMAIL PROTECTED]
---
arch/powerpc/kernel/pci_64.c |2 ++
On Sat, Jun 09, 2007 at 01:12:21PM -0700, Auke Kok wrote:
Since the PCI bus class and revision are in the same dword, we
can fill in both in the same read.
Other non-x86 arches use different methods to fill in these values,
make sure to adjust those too.
Yeah, this looks good to me.
I
14 matches
Mail list logo
