Re: [PATCH] PCI: altera-msi: Remove irq handler and data in one go

2020-11-12 Thread Thomas Gleixner
On Thu, Nov 12 2020 at 08:26, Bjorn Helgaas wrote: > On Thu, Nov 12, 2020 at 02:50:42PM +0100, Thomas Gleixner wrote: >> So I had a closer look and the reason why it only matters for the >> chained handler case is that >> >>__irq_set_handler(..., is_chained = true, ...) >> >> starts up the

Re: [PATCH] PCI: altera-msi: Remove irq handler and data in one go

2020-11-12 Thread Bjorn Helgaas
On Thu, Nov 12, 2020 at 02:50:42PM +0100, Thomas Gleixner wrote: > On Thu, Nov 12 2020 at 12:28, Thomas Gleixner wrote: > > On Wed, Nov 11 2020 at 16:16, Bjorn Helgaas wrote: > >> On Wed, Nov 11, 2020 at 10:43:55PM +0100, Martin Kaiser wrote: > >> Thomas, it looks like irq_domain_set_info() and

Re: [PATCH] PCI: altera-msi: Remove irq handler and data in one go

2020-11-12 Thread Thomas Gleixner
On Thu, Nov 12 2020 at 12:28, Thomas Gleixner wrote: > On Wed, Nov 11 2020 at 16:16, Bjorn Helgaas wrote: >> On Wed, Nov 11, 2020 at 10:43:55PM +0100, Martin Kaiser wrote: >> Thomas, it looks like irq_domain_set_info() and msi_domain_ops_init() >> set the handler itself before setting the handler

Re: [PATCH] PCI: altera-msi: Remove irq handler and data in one go

2020-11-12 Thread Thomas Gleixner
On Wed, Nov 11 2020 at 16:16, Bjorn Helgaas wrote: > On Wed, Nov 11, 2020 at 10:43:55PM +0100, Martin Kaiser wrote: >> This function uses the error status from irq_set_handler_data(). >> irq_set_chained_handler_and_data() returns no such error status. Is it >> ok to drop the error handling? > >

Re: [PATCH] PCI: altera-msi: Remove irq handler and data in one go

2020-11-11 Thread Bjorn Helgaas
[+cc Thomas for handler/data order question at end] On Wed, Nov 11, 2020 at 10:43:55PM +0100, Martin Kaiser wrote: > Thus wrote Bjorn Helgaas (helg...@kernel.org): > > On Tue, Nov 10, 2020 at 03:21:36PM -0600, Bjorn Helgaas wrote: > > > On Sun, Nov 08, 2020 at 08:11:40PM +0100, Martin Kaiser

Re: [PATCH] PCI: altera-msi: Remove irq handler and data in one go

2020-11-11 Thread Martin Kaiser
Thus wrote Bjorn Helgaas (helg...@kernel.org): > [+cc Florian, sorry, I hadn't seen your ack when I sent the below] > On Tue, Nov 10, 2020 at 03:21:36PM -0600, Bjorn Helgaas wrote: > > [+cc Nicolas, Jingoo, Gustavo, Toan] > > On Sun, Nov 08, 2020 at 08:11:40PM +0100, Martin Kaiser wrote: > > >

Re: [PATCH] PCI: altera-msi: Remove irq handler and data in one go

2020-11-10 Thread Bjorn Helgaas
[+cc Florian, sorry, I hadn't seen your ack when I sent the below] On Tue, Nov 10, 2020 at 03:21:36PM -0600, Bjorn Helgaas wrote: > [+cc Nicolas, Jingoo, Gustavo, Toan] > > On Sun, Nov 08, 2020 at 08:11:40PM +0100, Martin Kaiser wrote: > > Replace the two separate calls for removing the irq

Re: [PATCH] PCI: altera-msi: Remove irq handler and data in one go

2020-11-10 Thread Bjorn Helgaas
[+cc Nicolas, Jingoo, Gustavo, Toan] On Sun, Nov 08, 2020 at 08:11:40PM +0100, Martin Kaiser wrote: > Replace the two separate calls for removing the irq handler and data with a > single irq_set_chained_handler_and_data() call. This is similar to these: 36f024ed8fc9 ("PCI/MSI: pci-xgene-msi:

[PATCH] PCI: altera-msi: Remove irq handler and data in one go

2020-11-08 Thread Martin Kaiser
Replace the two separate calls for removing the irq handler and data with a single irq_set_chained_handler_and_data() call. Signed-off-by: Martin Kaiser --- drivers/pci/controller/pcie-altera-msi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git