Re: [PATCH] PCI: dwc: Move allocate and map page for msi out of dw_pcie_msi_init()

2020-09-25 Thread Jisheng Zhang
On Thu, 24 Sep 2020 07:28:25 -0600 Rob Herring wrote: > CAUTION: Email originated externally, do not click links or open attachments > unless you recognize the sender and know the content is safe. > > > On Thu, Sep 24, 2020 at 5:00 AM Ard Biesheuvel wrote: > > > > On Wed, 23 Sep 2020 at 08:28

Re: [PATCH] PCI: dwc: Move allocate and map page for msi out of dw_pcie_msi_init()

2020-09-24 Thread Rob Herring
On Thu, Sep 24, 2020 at 8:33 AM Ard Biesheuvel wrote: > > On Thu, 24 Sep 2020 at 15:45, Ard Biesheuvel wrote: > > > > On Thu, 24 Sep 2020 at 15:28, Rob Herring wrote: > > > > > > On Thu, Sep 24, 2020 at 5:00 AM Ard Biesheuvel wrote: > > > > > > > > On Wed, 23 Sep 2020 at 08:28, Jisheng Zhang >

Re: [PATCH] PCI: dwc: Move allocate and map page for msi out of dw_pcie_msi_init()

2020-09-24 Thread Ard Biesheuvel
On Thu, 24 Sep 2020 at 15:45, Ard Biesheuvel wrote: > > On Thu, 24 Sep 2020 at 15:28, Rob Herring wrote: > > > > On Thu, Sep 24, 2020 at 5:00 AM Ard Biesheuvel wrote: > > > > > > On Wed, 23 Sep 2020 at 08:28, Jisheng Zhang > > > wrote: > > > > > > > > Currently, dw_pcie_msi_init() allocates an

Re: [PATCH] PCI: dwc: Move allocate and map page for msi out of dw_pcie_msi_init()

2020-09-24 Thread Ard Biesheuvel
On Thu, 24 Sep 2020 at 15:28, Rob Herring wrote: > > On Thu, Sep 24, 2020 at 5:00 AM Ard Biesheuvel wrote: > > > > On Wed, 23 Sep 2020 at 08:28, Jisheng Zhang > > wrote: > > > > > > Currently, dw_pcie_msi_init() allocates and maps page for msi, then > > > program the PCIE_MSI_ADDR_LO and PCIE_M

Re: [PATCH] PCI: dwc: Move allocate and map page for msi out of dw_pcie_msi_init()

2020-09-24 Thread Rob Herring
On Thu, Sep 24, 2020 at 5:00 AM Ard Biesheuvel wrote: > > On Wed, 23 Sep 2020 at 08:28, Jisheng Zhang > wrote: > > > > Currently, dw_pcie_msi_init() allocates and maps page for msi, then > > program the PCIE_MSI_ADDR_LO and PCIE_MSI_ADDR_HI. The Root Complex > > may lose power during suspend-to-

Re: [PATCH] PCI: dwc: Move allocate and map page for msi out of dw_pcie_msi_init()

2020-09-24 Thread Ard Biesheuvel
On Wed, 23 Sep 2020 at 08:28, Jisheng Zhang wrote: > > Currently, dw_pcie_msi_init() allocates and maps page for msi, then > program the PCIE_MSI_ADDR_LO and PCIE_MSI_ADDR_HI. The Root Complex > may lose power during suspend-to-RAM, so when we resume, we want to > redo the latter but not the forme

Re: [PATCH] PCI: dwc: Move allocate and map page for msi out of dw_pcie_msi_init()

2020-09-24 Thread Jisheng Zhang
Hi Rob, On Wed, 23 Sep 2020 10:41:45 -0600 Rob Herring wrote: > > On Wed, Sep 23, 2020 at 12:27 AM Jisheng Zhang > wrote: > > > > Currently, dw_pcie_msi_init() allocates and maps page for msi, then > > program the PCIE_MSI_ADDR_LO and PCIE_MSI_ADDR_HI. The Root Complex > > may lose power during

Re: [PATCH] PCI: dwc: Move allocate and map page for msi out of dw_pcie_msi_init()

2020-09-23 Thread Rob Herring
On Wed, Sep 23, 2020 at 12:27 AM Jisheng Zhang wrote: > > Currently, dw_pcie_msi_init() allocates and maps page for msi, then > program the PCIE_MSI_ADDR_LO and PCIE_MSI_ADDR_HI. The Root Complex > may lose power during suspend-to-RAM, so when we resume, we want to > redo the latter but not the fo

[PATCH] PCI: dwc: Move allocate and map page for msi out of dw_pcie_msi_init()

2020-09-22 Thread Jisheng Zhang
Currently, dw_pcie_msi_init() allocates and maps page for msi, then program the PCIE_MSI_ADDR_LO and PCIE_MSI_ADDR_HI. The Root Complex may lose power during suspend-to-RAM, so when we resume, we want to redo the latter but not the former. If designware based driver (for example, pcie-tegra194.c) c